openstack/neutron-dynamic-routing
Code Issues Proposed changes

bgp: Gracefully handle missing last_known_router_id

Browse Source 
When a server is deleted before its floating IP has been disassociated,
the notification doens't contain a `last_known_router_id` key, which
results in a `KeyError` exception being thrown.

This commit gracefully handles this situation by setting
`last_router_id` to `None` when `last_known_router_id` is missing.

Change-Id: If127a33cec7ce6c4d264a191df37c30decab4daa
Closes-Bug: #1795816
This commit is contained in:
Benoît Knecht 2019-06-14 10:12:18 +02:00
parent a32c6f8c23
commit 4780fe548b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron_dynamic_routing/services/bgp/bgp_plugin.py
View File

@ -230,7 +230,7 @@ class BgpPlugin(service_base.ServicePluginBase,
ctx = context.get_admin_context() ctx = context.get_admin_context()
new_router_id = kwargs['router_id'] new_router_id = kwargs['router_id']
last_router_id = kwargs['last_known_router_id'] last_router_id = kwargs.get('last_known_router_id')
floating_ip_address = kwargs['floating_ip_address'] floating_ip_address = kwargs['floating_ip_address']
dest = floating_ip_address + '/32' dest = floating_ip_address + '/32'
bgp_speakers = self._bgp_speakers_for_gw_network_by_family( bgp_speakers = self._bgp_speakers_for_gw_network_by_family(