openstack/neutron-dynamic-routing
Code Issues Proposed changes

Fix unit tests for floating IP creation

Browse Source 
Remove unnecessary settings of None in the floating IP
creation.

This is now dealt correctly with by neutron.

Change-Id: Ifa7195bc0c58eca077579039705bb1738f3d362e
This commit is contained in:
Gary Kotton 2017-12-18 23:14:08 -08:00 committed by garyk
parent 3562fb4305
commit 9a6fcb6205
1 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
neutron_dynamic_routing/tests/unit/db/test_bgp_db.py
View File

@ -776,8 +776,6 @@ class BgpTests(BgpEntityCreationMixin):
fixed_port_data)
fip_data = {'floatingip': {'floating_network_id': gw_net_id,
'tenant_id': tenant_id,
'subnet_id': None,
'floating_ip_address': None,
'port_id': fixed_port['id']}}
fip = self.l3plugin.create_floatingip(self.context, fip_data)
fip_prefix = fip['floating_ip_address'] + '/32'
@ -830,8 +828,6 @@ class BgpTests(BgpEntityCreationMixin):
fixed_port_data)
fip_data = {'floatingip': {'floating_network_id': gw_net_id,
'tenant_id': tenant_id,
'subnet_id': None,
'floating_ip_address': None,
'port_id': fixed_port['id']}}
fip = self.l3plugin.create_floatingip(self.context, fip_data)
fip_prefix = fip['floating_ip_address'] + '/32'
@ -896,8 +892,6 @@ class BgpTests(BgpEntityCreationMixin):
'test-host')
fip_data = {'floatingip': {'floating_network_id': gw_net_id,
'tenant_id': tenant_id,
'subnet_id': None,
'floating_ip_address': None,
'port_id': fixed_port['id']}}
fip = self.l3plugin.create_floatingip(self.context, fip_data)
fip_prefix = fip['floating_ip_address'] + '/32'
@ -963,8 +957,6 @@ class BgpTests(BgpEntityCreationMixin):
'test-host')
fip_data = {'floatingip': {'floating_network_id': gw_net_id,
'tenant_id': tenant_id,
'subnet_id': None,
'floating_ip_address': None,
'port_id': fixed_port['id']}}
fip = self.l3plugin.create_floatingip(self.context, fip_data)
fip_prefix = fip['floating_ip_address'] + '/32'
@ -1021,8 +1013,6 @@ class BgpTests(BgpEntityCreationMixin):
'test-host')
fip_data = {'floatingip': {'floating_network_id': gw_net_id,
'tenant_id': tenant_id,
'subnet_id': None,
'floating_ip_address': None,
'port_id': fixed_port['id']}}
fip = self.l3plugin.create_floatingip(self.context, fip_data)
fip_prefix = fip['floating_ip_address'] + '/32'
@ -1069,8 +1059,6 @@ class BgpTests(BgpEntityCreationMixin):
fixed_port_data)
fip_data = {'floatingip': {'floating_network_id': gw_net_id,
'tenant_id': tenant_id,
'subnet_id': None,
'floating_ip_address': None,
'port_id': fixed_port['id']}}
fip = self.l3plugin.create_floatingip(self.context, fip_data)
fip_prefix = fip['floating_ip_address'] + '/32'
@ -1155,8 +1143,6 @@ class BgpTests(BgpEntityCreationMixin):
for port_id in port_ids:
fip_data = {'floatingip': {'floating_network_id': ext_net_id,
'tenant_id': tenant_id,
'subnet_id': None,
'floating_ip_address': None,
'port_id': port_id}}
fip = self.l3plugin.create_floatingip(self.context, fip_data)
fips.append(fip)
@ -1299,8 +1285,6 @@ class BgpTests(BgpEntityCreationMixin):
dvr_gw_ip = fip_gw['fixed_ips'][0]['ip_address']
fip_data = {'floatingip': {'floating_network_id': gw_net_id,
'tenant_id': tenant_id,
'subnet_id': None,
'floating_ip_address': None,
'port_id': ports[0]['id']}}
fip = self.l3plugin.create_floatingip(self.context, fip_data)
fip_address = fip['floating_ip_address']