openstack
/
neutron-dynamic-routing
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review-1

(1 comment)

Patch-set: 4
Reviewer: Gerrit User 16137 <16137@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, be5a3600895e1cbc3e6907eefb186e7b0e2870f8
Attention: {"person_ident":"Gerrit User 35432 \u003c35432@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_16137\u003e replied on the change"}
This commit is contained in:
Gerrit User 16137 2024-01-23 07:56:29 +00:00 committed by Gerrit Code Review
parent 2299056e9f
commit d5d58ef099
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
54257b431810e6f7ddc425b78607dbd72ebc0f05 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "1a578c07_c45c976c",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 16137
},
"writtenOn": "2024-01-23T07:56:29Z",
"side": 1,
"message": "\u003eThis type of advertisement makes no sense because the IP version of\nthe route must always be the same as the next-hop.\n\nThis is not really true though? We explicitly enabled MP-BGP capabilities in [1] to make this possible and this would be up to the operator configuring the peers, do you mean that you want a config option for this to filter it out and not remove the possibility completely?\n\n[1] https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/608302",
"revId": "54257b431810e6f7ddc425b78607dbd72ebc0f05",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}