openstack
/
neutron-dynamic-routing
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(2 comments)

Patch-set: 3
CC: Gerrit User 8313 <8313@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 35432 \u003c35432@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8313\u003e replied on the change"}
This commit is contained in:
Gerrit User 8313 2024-01-10 12:50:39 +00:00 committed by Gerrit Code Review
parent 299d21b739
commit de5cc05dd2
1 changed files with 40 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
eed237f8b0a8971bc78e333c3a0adc4da0700b68
View File

@ -1,5 +1,28 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "68e7b2ef_48b018a2",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 11,
"author": {
"id": 8313
},
"writtenOn": "2024-01-10T12:50:39Z",
"side": 1,
"message": "nit: could you please break these lines to less than 72 chars?\nSee : https://wiki.openstack.org/wiki/GitCommitMessages",
"range": {
"startLine": 8,
"startChar": 0,
"endLine": 11,
"endChar": 118
},
"revId": "eed237f8b0a8971bc78e333c3a0adc4da0700b68",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -33,6 +56,23 @@
"message": "recheck devstack fixed",
"revId": "eed237f8b0a8971bc78e333c3a0adc4da0700b68",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "02798b30_54f1914f",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 8313
},
"writtenOn": "2024-01-10T12:50:39Z",
"side": 1,
"message": "Thanks for the patch, my only concern/nit is for the commit msg.",
"revId": "eed237f8b0a8971bc78e333c3a0adc4da0700b68",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}