74 lines
2.6 KiB
Plaintext
74 lines
2.6 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "c470304b_ea30847c",
|
|
"filename": "neutron_dynamic_routing/db/bgp_dragentscheduler_db.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 42,
|
|
"author": {
|
|
"id": 13252
|
|
},
|
|
"writtenOn": "2021-11-03T19:03:26Z",
|
|
"side": 1,
|
|
"message": "After having built the option to test via n-t-p option I have not switched the default for now, but I still think that that would be the proper path forward. So I would like to ask reviewers on their opinion about this: Do we need to wait a cycle before we switch the default or should we do it at once? Or maybe not at all?\n\nIf we intend to switch later, should we at least announce that plan in the release note?",
|
|
"revId": "1a40f3706d3b0b01e27904b1e1423bd209cd7771",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "526fd4c3_5835b7f6",
|
|
"filename": "neutron_dynamic_routing/db/bgp_dragentscheduler_db.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 42,
|
|
"author": {
|
|
"id": 16137
|
|
},
|
|
"writtenOn": "2021-11-03T20:33:30Z",
|
|
"side": 1,
|
|
"message": "I think we shoud notify with a deprecation/upgrade in release note, then change next release, that would prepare anybody for the default change one release prior. Then also a new release for the default change.",
|
|
"parentUuid": "c470304b_ea30847c",
|
|
"revId": "1a40f3706d3b0b01e27904b1e1423bd209cd7771",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "140ec47e_6413febc",
|
|
"filename": "neutron_dynamic_routing/db/bgp_dragentscheduler_db.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 42,
|
|
"author": {
|
|
"id": 8313
|
|
},
|
|
"writtenOn": "2021-11-04T10:25:10Z",
|
|
"side": 1,
|
|
"message": "agree",
|
|
"parentUuid": "526fd4c3_5835b7f6",
|
|
"revId": "1a40f3706d3b0b01e27904b1e1423bd209cd7771",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "c5b1ec6e_64c8d27b",
|
|
"filename": "releasenotes/notes/add-static-scheduler-a3b0f54b964ae306.yaml",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 9,
|
|
"author": {
|
|
"id": 8313
|
|
},
|
|
"writtenOn": "2021-11-04T10:27:46Z",
|
|
"side": 1,
|
|
"message": "Could you please add a deprecation section or a note that the plan is to change the default scheduler driver?",
|
|
"revId": "1a40f3706d3b0b01e27904b1e1423bd209cd7771",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |