openstack
/
neutron-fwaas
Code Issues Proposed changes

Merge "Fix bug when removing a port from the firewall group"

This commit is contained in:
Zuul 2019-07-23 21:41:04 +00:00 committed by Gerrit Code Review
parent e6e5599876 90a2707ccf
commit 243a7ef575
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
neutron_fwaas/services/firewall/service_drivers/agents/agents.py
View File

@ -326,9 +326,10 @@ class FirewallAgentDriver(driver_api.FirewallDriverDB,
)
# last-port drives agent to ack with status to set state to INACTIVE
# Set last-port to True if there are no ports in the new group,
# but the old group had ports
fwg_with_rules['last-port'] = (old_firewall_group['ports'] and
# Set last-port to True if there are no ports in the new group and
# the old group had the same number of ports that need to be deleted.
fwg_with_rules['last-port'] = (len(old_firewall_group['ports']) == len(
fwg_with_rules['del-port-ids']) and
not(new_firewall_group['ports']))
LOG.debug("update_firewall_group %s: Add Ports: %s, Del Ports: %s",