openstack
/
neutron-fwaas
Code Issues Proposed changes

FWaaS fix comment typos 

Fix minor set of comment typos in FWaaS files:
"interfacesr" -> "interfaces"
"dictionry" -> "dictionary"
"protacal" -> "protocol"
"implmentation" -> "implementation"
"libary" -> "library"
"firewal" -> "firewall"

Closes-Bug: #1509045

Change-Id: Iafa2cc874e680a256037c9e4d7949b0a2cd0c6f0
This commit is contained in:
James Arendt 2015-10-22 12:02:05 -07:00
parent 64c0e6a56c
commit e2ddce97d3
5 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
neutron_fwaas/services/firewall/drivers/cisco/csr_acl_driver.py
View File

@ -300,16 +300,16 @@ class CsrAclDriver(fwaas_base.FwaasDriverBase):
acl_id = firewall['vendor_ext'].get('acl_id')
if not acl_id:
LOG.error(_LE("firewal (%s) has no acl_id"), firewall['id'])
LOG.error(_LE("firewall (%s) has no acl_id"), firewall['id'])
return False
csr = self._get_csr_host(firewall['vendor_ext'])
return self._delete_acl(csr, acl_id)
def _update_firewall(self, firewall):
"""Update ACL and associated interfacesr.
"""Update ACL and associated interfaces.
:param firewall: firewall dictionry
:param firewall: firewall dictionary
:return: True and status_data if OK
:return: False and {} if there is an error
"""
@ -321,7 +321,7 @@ class CsrAclDriver(fwaas_base.FwaasDriverBase):
acl_id = firewall['vendor_ext'].get('acl_id')
if not acl_id:
LOG.error(_LE("firewal (%s) has no acl_id"), firewall['id'])
LOG.error(_LE("firewall (%s) has no acl_id"), firewall['id'])
return False, {}
csr = self._get_csr_host(firewall['vendor_ext'])

2
neutron_fwaas/services/firewall/drivers/mcafee/ngfw_fwaas.py
View File

@ -228,7 +228,7 @@ class NgfwFwaasDriver(fwaas_base.FwaasDriverBase):
service_dict = {"service": [srv_ref]}
elif rule['protocol'] is None:
# protocal "ANY" is translated to accept all, no service create
# protocol "ANY" is translated to accept all, no service create
# here
# TODO(yalie): add rules for different protocol, not ignore the
# other value like ports.

2
neutron_fwaas/services/firewall/drivers/mcafee/smc_api.py
View File

@ -60,7 +60,7 @@ class SMCAPIConnection(object):
For login/logout operation, users should set server IP, API version and
auth key first. For get/put/delete operation, users should provide the
target element'path, and special json format data section followed "SMC
target element's path and special json format data section following "SMC
API User's Guide".
"""
def __init__(self, host, api_version, authentication_key):

2
neutron_fwaas/tests/functional/test_fwaas_driver.py
View File

@ -21,7 +21,7 @@ from neutron.tests.functional import base
class TestFWaaSDriver(base.BaseSudoTestCase):
"""Test the Iptables implmentation of the FWaaS driver."""
"""Test the iptables implementation of the FWaaS driver."""
# NOTE: Tests may be added/removed/changed, when this is fleshed out
# in future commits.

2
neutron_fwaas/tests/unit/services/firewall/drivers/cisco/test_csr_firewall_svc_helper.py
View File

@ -20,7 +20,7 @@ from neutron.plugins.common import constants
from neutron.tests import base
# Mocking imports of 3rd party cisco library in unit tests and all modules
# that depends on this libary.
# that depends on this library.
with mock.patch.dict(sys.modules, {
'networking_cisco': mock.Mock(),
'networking_cisco.plugins': mock.Mock().plugins,