FWaaS fix comment typos
Fix minor set of comment typos in FWaaS files: "interfacesr" -> "interfaces" "dictionry" -> "dictionary" "protacal" -> "protocol" "implmentation" -> "implementation" "libary" -> "library" "firewal" -> "firewall" Closes-Bug: #1509045 Change-Id: Iafa2cc874e680a256037c9e4d7949b0a2cd0c6f0
This commit is contained in:
parent
64c0e6a56c
commit
e2ddce97d3
@ -300,16 +300,16 @@ class CsrAclDriver(fwaas_base.FwaasDriverBase):
|
|||||||
|
|
||||||
acl_id = firewall['vendor_ext'].get('acl_id')
|
acl_id = firewall['vendor_ext'].get('acl_id')
|
||||||
if not acl_id:
|
if not acl_id:
|
||||||
LOG.error(_LE("firewal (%s) has no acl_id"), firewall['id'])
|
LOG.error(_LE("firewall (%s) has no acl_id"), firewall['id'])
|
||||||
return False
|
return False
|
||||||
|
|
||||||
csr = self._get_csr_host(firewall['vendor_ext'])
|
csr = self._get_csr_host(firewall['vendor_ext'])
|
||||||
return self._delete_acl(csr, acl_id)
|
return self._delete_acl(csr, acl_id)
|
||||||
|
|
||||||
def _update_firewall(self, firewall):
|
def _update_firewall(self, firewall):
|
||||||
"""Update ACL and associated interfacesr.
|
"""Update ACL and associated interfaces.
|
||||||
|
|
||||||
:param firewall: firewall dictionry
|
:param firewall: firewall dictionary
|
||||||
:return: True and status_data if OK
|
:return: True and status_data if OK
|
||||||
:return: False and {} if there is an error
|
:return: False and {} if there is an error
|
||||||
"""
|
"""
|
||||||
@ -321,7 +321,7 @@ class CsrAclDriver(fwaas_base.FwaasDriverBase):
|
|||||||
|
|
||||||
acl_id = firewall['vendor_ext'].get('acl_id')
|
acl_id = firewall['vendor_ext'].get('acl_id')
|
||||||
if not acl_id:
|
if not acl_id:
|
||||||
LOG.error(_LE("firewal (%s) has no acl_id"), firewall['id'])
|
LOG.error(_LE("firewall (%s) has no acl_id"), firewall['id'])
|
||||||
return False, {}
|
return False, {}
|
||||||
|
|
||||||
csr = self._get_csr_host(firewall['vendor_ext'])
|
csr = self._get_csr_host(firewall['vendor_ext'])
|
||||||
|
@ -228,7 +228,7 @@ class NgfwFwaasDriver(fwaas_base.FwaasDriverBase):
|
|||||||
service_dict = {"service": [srv_ref]}
|
service_dict = {"service": [srv_ref]}
|
||||||
|
|
||||||
elif rule['protocol'] is None:
|
elif rule['protocol'] is None:
|
||||||
# protocal "ANY" is translated to accept all, no service create
|
# protocol "ANY" is translated to accept all, no service create
|
||||||
# here
|
# here
|
||||||
# TODO(yalie): add rules for different protocol, not ignore the
|
# TODO(yalie): add rules for different protocol, not ignore the
|
||||||
# other value like ports.
|
# other value like ports.
|
||||||
|
@ -60,7 +60,7 @@ class SMCAPIConnection(object):
|
|||||||
|
|
||||||
For login/logout operation, users should set server IP, API version and
|
For login/logout operation, users should set server IP, API version and
|
||||||
auth key first. For get/put/delete operation, users should provide the
|
auth key first. For get/put/delete operation, users should provide the
|
||||||
target element'path, and special json format data section followed "SMC
|
target element's path and special json format data section following "SMC
|
||||||
API User's Guide".
|
API User's Guide".
|
||||||
"""
|
"""
|
||||||
def __init__(self, host, api_version, authentication_key):
|
def __init__(self, host, api_version, authentication_key):
|
||||||
|
@ -21,7 +21,7 @@ from neutron.tests.functional import base
|
|||||||
|
|
||||||
class TestFWaaSDriver(base.BaseSudoTestCase):
|
class TestFWaaSDriver(base.BaseSudoTestCase):
|
||||||
|
|
||||||
"""Test the Iptables implmentation of the FWaaS driver."""
|
"""Test the iptables implementation of the FWaaS driver."""
|
||||||
|
|
||||||
# NOTE: Tests may be added/removed/changed, when this is fleshed out
|
# NOTE: Tests may be added/removed/changed, when this is fleshed out
|
||||||
# in future commits.
|
# in future commits.
|
||||||
|
@ -20,7 +20,7 @@ from neutron.plugins.common import constants
|
|||||||
from neutron.tests import base
|
from neutron.tests import base
|
||||||
|
|
||||||
# Mocking imports of 3rd party cisco library in unit tests and all modules
|
# Mocking imports of 3rd party cisco library in unit tests and all modules
|
||||||
# that depends on this libary.
|
# that depends on this library.
|
||||||
with mock.patch.dict(sys.modules, {
|
with mock.patch.dict(sys.modules, {
|
||||||
'networking_cisco': mock.Mock(),
|
'networking_cisco': mock.Mock(),
|
||||||
'networking_cisco.plugins': mock.Mock().plugins,
|
'networking_cisco.plugins': mock.Mock().plugins,
|
||||||
|
Loading…
Reference in New Issue
Block a user