openstack
/
neutron-fwaas
Code Issues Proposed changes

FWaaS Disable nonstandard-exception due to neutron_lib shims 

The current FWaaS will fail pylint:
pylint runtests: commands[0] | pylint --rcfile=.pylintrc
--output-format=colorized neutron_fwaas
************* Module neutron_fwaas.db.firewall.firewall_db
W:621,12: Exception doesn't inherit from standard "Exception"
class (nonstandard-exception)
ERROR: InvocationError:
'/opt/stack/neutron-fwaas/.tox/pylint/bin/pylint
--rcfile=.pylintrc --output-format=colorized neutron_fwaas'

Looks like due to recent change
"FWaaS: make use of neutron_lib exceptions."
The culprit code:
   raise l3.RouterInUse(router_id=router['id'])
imports into fwaas from base Neutron as a neutron.common.exception,
not a neutron_lib.exceptions.

Quick investigation shows the neutron added following to .pylintrc:
neutron_lib shims
 nonstandard-exception,

Adding same to neutron_fwaas, complete with the TODO so will
remember to remove when neutron_lib shims are cleaned up.

Change-Id: I9bf2001e8c12038e152422051e2fb2a10214575c
This commit is contained in:
James Arendt 2016-03-17 19:40:39 -07:00
parent 3605570eca
commit e30e192d31
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.pylintrc
View File

@ -62,6 +62,8 @@ disable=
unused-argument,
unused-import,
unused-variable,
# TODO(dougwig) - disable nonstandard-exception while we have neutron_lib shims
nonstandard-exception,
# "C" Coding convention violations
bad-continuation,
invalid-name,