Update patch set 2
Patch Set 2: Code-Review-1 (3 comments) A few comments... Patch-set: 2 Reviewer: Gerrit User 11628 <11628@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
c8c18d7fac
commit
623d3489f3
@ -1,5 +1,22 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a4dcd0f_b341b10d",
|
||||
"filename": "README.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 7,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2015-08-04T23:46:57Z",
|
||||
"side": 1,
|
||||
"message": "Huh?",
|
||||
"revId": "8411ebf1ee5826f729b6a46999020ab6b7f73e98",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a4dcd0f_b8fe6e69",
|
||||
@ -17,6 +34,23 @@
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a4dcd0f_130985dd",
|
||||
"filename": "setup.cfg",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 18,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2015-08-04T23:46:57Z",
|
||||
"side": 1,
|
||||
"message": "Same question here, do we need 2.6 and 3.3?",
|
||||
"revId": "8411ebf1ee5826f729b6a46999020ab6b7f73e98",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a4dcd0f_f8ee368a",
|
||||
@ -33,6 +67,24 @@
|
||||
"revId": "8411ebf1ee5826f729b6a46999020ab6b7f73e98",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a4dcd0f_73dec96e",
|
||||
"filename": "tox.ini",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 3,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2015-08-04T23:46:57Z",
|
||||
"side": 1,
|
||||
"message": "According to the setup.cfg we only support 2.7, however there is a tox.ini for 34.\n\nI say py26 and py33 should go if this isn\u0027t tied to some strange horizon requirements.",
|
||||
"parentUuid": "1a4dcd0f_f8ee368a",
|
||||
"revId": "8411ebf1ee5826f729b6a46999020ab6b7f73e98",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue
Block a user