neutron-lbaas-dashboard/545fde5a7fe5f57dbfafe5cee71052ab79ec6547
Gerrit User 6162 4572e8e18d Update patch set 4
Patch Set 4:

(8 comments)

I'll pull these down and test them out.  Added a few minor comments but will give more the next round.

Patch-set: 4
Reviewer: Gerrit User 6162 <6162@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
2015-09-09 23:38:53 +00:00

157 lines
4.6 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "da20952f_09288384",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 8,
"author": {
"id": 6162
},
"writtenOn": "2015-09-09T23:38:53Z",
"side": 1,
"message": "probably needs to reference a blueprint",
"revId": "545fde5a7fe5f57dbfafe5cee71052ab79ec6547",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da20952f_c9212ba0",
"filename": "neutron_lbaas_dashboard/api/lbaasv2.py",
"patchSetId": 4
},
"lineNbr": 72,
"author": {
"id": 6162
},
"writtenOn": "2015-09-09T23:38:53Z",
"side": 1,
"message": "not sure you want all this commented code here",
"revId": "545fde5a7fe5f57dbfafe5cee71052ab79ec6547",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da20952f_293307f8",
"filename": "neutron_lbaas_dashboard/api/lbaasv2.py",
"patchSetId": 4
},
"lineNbr": 87,
"author": {
"id": 6162
},
"writtenOn": "2015-09-09T23:38:53Z",
"side": 1,
"message": "same",
"revId": "545fde5a7fe5f57dbfafe5cee71052ab79ec6547",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da20952f_4caa521b",
"filename": "neutron_lbaas_dashboard/dashboards/project/loadbalancersv2/panel.py",
"patchSetId": 4
},
"lineNbr": 3,
"author": {
"id": 12403
},
"writtenOn": "2015-08-26T21:00:21Z",
"side": 1,
"message": "pep8 complains about including Author: tags.",
"revId": "545fde5a7fe5f57dbfafe5cee71052ab79ec6547",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da20952f_495c3b19",
"filename": "neutron_lbaas_dashboard/dashboards/project/loadbalancersv2/panel.py",
"patchSetId": 4
},
"lineNbr": 30,
"author": {
"id": 6162
},
"writtenOn": "2015-09-09T23:38:53Z",
"side": 1,
"message": "This can probably be left out until you are ready to implement. I believe the super class method just returns True by default.",
"revId": "545fde5a7fe5f57dbfafe5cee71052ab79ec6547",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da20952f_e9ce6fb6",
"filename": "neutron_lbaas_dashboard/dashboards/project/loadbalancersv2/templates/loadbalancersv2/_monitor_create.html",
"patchSetId": 4
},
"lineNbr": 17,
"author": {
"id": 6162
},
"writtenOn": "2015-09-09T23:38:53Z",
"side": 1,
"message": "I\u0027m not sure you want these comments here.",
"revId": "545fde5a7fe5f57dbfafe5cee71052ab79ec6547",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da20952f_c9cb6ba3",
"filename": "neutron_lbaas_dashboard/dashboards/project/loadbalancersv2/templates/loadbalancersv2/launch_lb.html",
"patchSetId": 4
},
"lineNbr": 19,
"author": {
"id": 6162
},
"writtenOn": "2015-09-09T23:38:53Z",
"side": 1,
"message": "same",
"revId": "545fde5a7fe5f57dbfafe5cee71052ab79ec6547",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da20952f_89bed3fe",
"filename": "neutron_lbaas_dashboard/dashboards/project/loadbalancersv2/templates/loadbalancersv2/ssl_cert.html",
"patchSetId": 4
},
"lineNbr": 18,
"author": {
"id": 6162
},
"writtenOn": "2015-09-09T23:38:53Z",
"side": 1,
"message": "more commented code",
"revId": "545fde5a7fe5f57dbfafe5cee71052ab79ec6547",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da20952f_e9350fa8",
"filename": "neutron_lbaas_dashboard/dashboards/project/loadbalancersv2/templates/loadbalancersv2/update_lb_step.html",
"patchSetId": 4
},
"lineNbr": 13,
"author": {
"id": 6162
},
"writtenOn": "2015-09-09T23:38:53Z",
"side": 1,
"message": "same",
"revId": "545fde5a7fe5f57dbfafe5cee71052ab79ec6547",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}