Move pylint checks to pep8 testenv

Replicates Change-Id: Ida6ae44a837d1761f5ce3e8a92f8850407f5cd16
from Neutron into Neutron-LBaaS project

This change proposes to move pylint violation checks to the pep8
testenv. This changes make pylint gating within Neutron as it would
participate in the vote.  Having pylint executed on a separate job makes
it difficult to handle potential unexpected breakages, because we need
to get infra involved. When we need to renable the job, it is equally
painful.

Furthermore, it also causes us to spin an extra node, when the checks
can easily be handled by the node for the pep8 job.

Finally, having pylint running with tox -epep8 "helps" developers
become aware of pylint violations sooner rather than later, if they
"forget" to run the pylint testenv too before submitting the change.

Change-Id: I814051122e2e71bc4e55ab283786651de722309f

tox.ini

@@ -44,9 +44,13 @@ sitepackages = True
 downloadcache = ~/cache/pip
 
 [testenv:pep8]
+deps =
+  {[testenv]deps}
+  pylint
 commands =
   sh ./tools/check_bash.sh
   flake8
+  pylint --rcfile=.pylintrc --output-format=colorized {posargs:neutron_lbaas}
   #neutron-db-manage check_migration
   #sh -c "find neutron_lbaas -type f -regex '.*\.pot?' -print0|xargs -0 -n 1 msgfmt --check-format -o /dev/null"
 whitelist_externals = sh
@@ -78,13 +82,6 @@ show-source = true
 builtins = _
 exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools,.ropeproject,rally-scenarios
 
-[testenv:pylint]
-deps =
-  {[testenv]deps}
-  pylint
-commands =
-  pylint --rcfile=.pylintrc --output-format=colorized {posargs:neutron_lbaas}
-
 [hacking]
 import_exceptions = neutron.i18n
 local-check-factory = neutron.hacking.checks.factory