From a9ad175f0be9b34287d41fdb76ee6a103e328bb6 Mon Sep 17 00:00:00 2001 From: Reedip Banerjee Date: Mon, 2 Nov 2015 10:24:44 +0530 Subject: [PATCH] Avoiding usage of mutables as default arguments Using Mutables objects as default arguments in function definition is a known Python pitfall. This patch fixes the issue in neutron-lbaas. Change-Id: Idb1cccbebec5dfedde04ee474036e67569406caa Closes-Bug: #1327473 (cherry picked from commit 0aac2d029a7ed9bff903a00a4ab194e277dfe06c) --- .../drivers/haproxy/sample_configs/sample_configs.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/neutron_lbaas/tests/unit/services/loadbalancer/drivers/haproxy/sample_configs/sample_configs.py b/neutron_lbaas/tests/unit/services/loadbalancer/drivers/haproxy/sample_configs/sample_configs.py index 9402d0191..bed76da0f 100644 --- a/neutron_lbaas/tests/unit/services/loadbalancer/drivers/haproxy/sample_configs/sample_configs.py +++ b/neutron_lbaas/tests/unit/services/loadbalancer/drivers/haproxy/sample_configs/sample_configs.py @@ -192,8 +192,9 @@ def sample_tls_sni_container_tuple(tls_container=None, tls_container_id=None): def sample_tls_container_tuple(id='cont_id_1', certificate=None, - private_key=None, intermediates=[], + private_key=None, intermediates=None, primary_cn=None): + intermediates = intermediates or [] sc = collections.namedtuple( 'tls_cert', 'id, certificate, private_key, intermediates, primary_cn')