openstack/neutron-lbaas
Code Issues Proposed changes

Add common test base class to hold common things.

Browse Source 
There are several common fixtures that every test case wants. Following
the pattern in Nova, add a common base test case class to hold these things.

Change-Id: I2d2cd91e5051d9cbf230e6f48985d6eddcb7b58a
This commit is contained in:
Monty Taylor 2013-02-23 10:35:28 +00:00
parent c586494f9c
commit b88bbd6157
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
HACKING.rst
View File

@ -199,7 +199,10 @@ bug that had no unit test, a new passing unit test should be added. If a
submitted bug fix does have a unit test, be sure to add a new one that fails submitted bug fix does have a unit test, be sure to add a new one that fails
without the patch and passes with the patch. without the patch and passes with the patch.
All unittest classes must ultimately inherit from testtools.TestCase. All unittest classes must ultimately inherit from testtools.TestCase. In the
Quantum test suite, this should be done by inheriting from
quantum.tests.base.BaseTestCase.
All setUp and tearDown methods must upcall using the super() method. All setUp and tearDown methods must upcall using the super() method.
tearDown methods should be avoided and addCleanup calls should be preferred. tearDown methods should be avoided and addCleanup calls should be preferred.
Never manually create tempfiles. Always use the tempfile fixtures from Never manually create tempfiles. Always use the tempfile fixtures from