openstack/neutron-lib
Code Issues Proposed changes

Don't override oslo.db tweaks for connection pool in tests

Browse Source 
This is in a way a follow-up for
Ia97d6cf24e554f7b3878dd301ae4e7e10a1c9998 that removed the same in
production neutron code to rely on default values inherited from
oslo.db. There is no clear need to override those settings in test
environment either, so at best it's boilerplate code.

Related-Bug: #1682307
Change-Id: Ie2e2dd0659b1cd6d8b8480e2d78d00475ab01b40
This commit is contained in:
Ihar Hrachyshka 2018-01-23 12:09:32 -08:00
parent dcf96cd351
commit 170e1764c4
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
neutron_lib/tests/_base.py
View File

@ -124,13 +124,7 @@ class BaseTestCase(testtools.TestCase):
mock.patch.object(exceptions.NeutronException, 'use_fatal_exceptions', mock.patch.object(exceptions.NeutronException, 'use_fatal_exceptions',
return_value=True).start() return_value=True).start()
# Update the default QueuePool parameters. These can be tweaked by the db_options.set_defaults(cfg.CONF, connection='sqlite://')
# conf variables - max_pool_size, max_overflow and pool_timeout
db_options.set_defaults(
cfg.CONF,
connection='sqlite://',
max_pool_size=10,
max_overflow=20, pool_timeout=10)
self.useFixture(fixtures.MonkeyPatch( self.useFixture(fixtures.MonkeyPatch(
'oslo_config.cfg.find_config_files', 'oslo_config.cfg.find_config_files',