openstack/neutron-lib
Code Issues Proposed changes

Insert references to debtcollector in review guidelines

Browse Source 
Change-Id: Ib63da82d628333bc11c4764416c702429ad38dac
Partially-Implements: blueprint neutron-lib
This commit is contained in:
Doug Wiegley 2015-11-23 10:49:08 -07:00
parent f696b74579
commit 447531ff45
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
doc/source/review-guidelines.rst
View File

@ -9,7 +9,10 @@ When reviewing neutron-lib changes, please be aware:
- Is all of the code shared? Don't move neutron-only code. - Is all of the code shared? Don't move neutron-only code.
- Is the interface good, or does it need to be refactored? - Is the interface good, or does it need to be refactored?
- Does it need new tests, specifically around the interface? - Does it need new tests, specifically around the interface? We want
100% unit coverage on this library, so if neutron does not yet have
a test, it needs to be added. Note that tests on things like constants
are uninteresting, but any code or interface should have a unit test.
- Is there a corresponding Depends-On review in neutron removing - Is there a corresponding Depends-On review in neutron removing
this code, and adding backwards compatibility shims for Mitaka? this code, and adding backwards compatibility shims for Mitaka?
@ -28,10 +31,9 @@ When reviewing neutron-lib changes, please be aware:
- Add keyword arguments - Add keyword arguments
* Removing the code from neutron should include a shim in neutron * Removing the code from neutron should include a shim in neutron
for the sake of subprojects. Refer to neutron/i18n.py and for the sake of subprojects. Refer to neutron/common/exceptions.py
neutron/common/exceptions.py for examples. Use of oslo's <insert name for an example. Please Use oslo's debtcollector library,
that I forget of deprecation tracker here>, example: <insert example example: http://docs.openstack.org/developer/debtcollector/
here.>
The above implies that if you add something, we are stuck with that interface The above implies that if you add something, we are stuck with that interface
for a long time, so be careful. for a long time, so be careful.