openstack/neutron-lib
Code Issues Proposed changes

Remove unnecessary attributes and specs from subnet_onboard API

Browse Source 
This change removes some items from the subnet_onboard API that
are problematic. In particular, this change removes the subnets
extension to subnetpools because it presents a redundant API for
creating/onboarding subnets.

http://lists.openstack.org/pipermail/openstack-discuss/2018-December/000796.html

Change-Id: Id84e7d01c67d369264e0a2961ffb70aea643f910
This commit is contained in:
Ryan Tidwell
2018-12-18 08:34:10 -06:00
committed by Slawek Kaplonski
parent 0e30615d59
commit 5780a773cc
2 changed files with 9 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
neutron_lib/api/definitions/subnet_onboard.py
View File

@@ -14,8 +14,6 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from neutron_lib.api import converters
from neutron_lib.api.definitions import subnet as subnet_def
from neutron_lib.api.definitions import subnetpool as subnetpool_def from neutron_lib.api.definitions import subnetpool as subnetpool_def
import neutron_lib.constants import neutron_lib.constants
@@ -24,28 +22,14 @@ IS_SHIM_EXTENSION = False
IS_STANDARD_ATTR_EXTENSION = False IS_STANDARD_ATTR_EXTENSION = False
NAME = "Subnet Onboard" NAME = "Subnet Onboard"
DESCRIPTION = "Provides support for onboarding subnets into subnet pools" DESCRIPTION = "Provides support for onboarding subnets into subnet pools"
UPDATED_TIMESTAMP = "2017-07-27T10:00:00-00:00" UPDATED_TIMESTAMP = "2018-12-18T09:00:00-00:00"
ONBOARD_SUBNETS = 'onboard_network_subnets' ONBOARD_SUBNETS = 'onboard_network_subnets'
ONBOARD_SUBNETS_SPECS = {
'id': {'type:uuid': None, 'required': True},
'network_id': {'type:uuid': None, 'required': True},
'ip_version': {'convert_to': converters.convert_to_int,
'type:values': [4, 6],
'required': True}
}
RESOURCE_ATTRIBUTE_MAP = { RESOURCE_ATTRIBUTE_MAP = {
subnetpool_def.COLLECTION_NAME: { subnetpool_def.COLLECTION_NAME: {
subnet_def.COLLECTION_NAME: {
'allow_post': True, 'allow_put': True, 'default': [],
'validate': {
'type:list_of_any_key_specs_or_none': ONBOARD_SUBNETS_SPECS
}
}
} }
} }

8
releasenotes/notes/update-subnet-onboard-api-267a9a37f6426d64.yaml Normal file
View File

@@ -0,0 +1,8 @@
---
other:
- |
This change removes the ``ONBOARD_SUBNETS_SPECS`` attribute extension
from the subnet onboard extension descriptor. This has been deemed to
be an unnecessary attribute extension during implementation and has been
removed. Because subnet onboard is not yet a completed Neutron feature,
the API definition is being updated to reflect this.