From 5180f8fd7f4988b8a07418fe965f63253fe14128 Mon Sep 17 00:00:00 2001
From: Hirofumi Ichihara <ichihara.hirofumi@lab.ntt.co.jp>
Date: Wed, 20 Jun 2018 16:04:13 +0900
Subject: [PATCH] Cleanup unused key-value in the attribute of l3

The external_fixed_ips is defined "convert_list_to" and "default"
in external_gateway_info attribute of l3 and l3_ext_gw_mode.
However, the "type:dict_or_nodata" validator doesn't manage
"convert_list_to" and "default" keys.
They are unused definitions so this patch removes them.

Change-Id: I9078a655adfd3a3567e4b4bd878e41ab68b1e1f2
---
 neutron_lib/api/definitions/l3.py                            | 3 ---
 neutron_lib/api/definitions/l3_ext_gw_mode.py                | 2 --
 .../notes/cleanup-unused-l3-attr-def-f0eab40813d17a2d.yaml   | 5 +++++
 3 files changed, 5 insertions(+), 5 deletions(-)
 create mode 100644 releasenotes/notes/cleanup-unused-l3-attr-def-f0eab40813d17a2d.yaml

diff --git a/neutron_lib/api/definitions/l3.py b/neutron_lib/api/definitions/l3.py
index 740d770e1..755bb44af 100644
--- a/neutron_lib/api/definitions/l3.py
+++ b/neutron_lib/api/definitions/l3.py
@@ -96,10 +96,7 @@ RESOURCE_ATTRIBUTE_MAP = {
                                    'network_id': {'type:uuid': None,
                                                   'required': True},
                                    'external_fixed_ips': {
-                                       'convert_list_to':
-                                           converters.convert_kvp_list_to_dict,
                                        'type:fixed_ips': None,
-                                       'default': None,
                                        'required': False,
                                    }
                                }
diff --git a/neutron_lib/api/definitions/l3_ext_gw_mode.py b/neutron_lib/api/definitions/l3_ext_gw_mode.py
index 0a73b5481..7d3ca8fa6 100644
--- a/neutron_lib/api/definitions/l3_ext_gw_mode.py
+++ b/neutron_lib/api/definitions/l3_ext_gw_mode.py
@@ -42,9 +42,7 @@ RESOURCE_ATTRIBUTE_MAP = {
                                     'convert_to':
                                         converters.convert_to_boolean},
                     'external_fixed_ips': {
-                        'convert_list_to': converters.convert_kvp_list_to_dict,
                         'type:fixed_ips': None,
-                        'default': None,
                         'required': False
                     }
                 }
diff --git a/releasenotes/notes/cleanup-unused-l3-attr-def-f0eab40813d17a2d.yaml b/releasenotes/notes/cleanup-unused-l3-attr-def-f0eab40813d17a2d.yaml
new file mode 100644
index 000000000..685743b7c
--- /dev/null
+++ b/releasenotes/notes/cleanup-unused-l3-attr-def-f0eab40813d17a2d.yaml
@@ -0,0 +1,5 @@
+---
+other:
+  - |
+    The ``convert_list_to`` and ``default`` parameters of external_fixed_ips
+    have been removed from l3 and l3_ext_gw_mode API definitions.