From 96b69b27dbb3bd511a11a77e72de9cb3fd2768cc Mon Sep 17 00:00:00 2001 From: Armando Migliaccio Date: Thu, 10 Nov 2016 12:11:05 -0800 Subject: [PATCH] Add missing is_loaded() method on directory's interface It is not supercritical, but it is nice to have. Change-Id: Iaf6c6c8d06ab1ea120da6957a5b3b6f1758f8550 --- neutron_lib/plugins/directory.py | 4 ++++ neutron_lib/tests/unit/plugins/test_directory.py | 5 +++++ .../notes/add-directory-is-loaded-e9da5b65824dddad.yaml | 5 +++++ 3 files changed, 14 insertions(+) create mode 100644 releasenotes/notes/add-directory-is-loaded-e9da5b65824dddad.yaml diff --git a/neutron_lib/plugins/directory.py b/neutron_lib/plugins/directory.py index 276fff950..22840b330 100644 --- a/neutron_lib/plugins/directory.py +++ b/neutron_lib/plugins/directory.py @@ -90,3 +90,7 @@ def get_plugins(): def get_unique_plugins(): return _get_plugin_directory().unique_plugins + + +def is_loaded(): + return _get_plugin_directory().is_loaded diff --git a/neutron_lib/tests/unit/plugins/test_directory.py b/neutron_lib/tests/unit/plugins/test_directory.py index 761f50f4d..ec79bbafa 100644 --- a/neutron_lib/tests/unit/plugins/test_directory.py +++ b/neutron_lib/tests/unit/plugins/test_directory.py @@ -59,6 +59,11 @@ class DirectoryTestCase(base.BaseTestCase): directory.add_plugin('foo2', fake_plugin) self.assertEqual(1, len(directory.get_unique_plugins())) + def test_is_loaded(self): + self.assertFalse(directory.is_loaded()) + directory.add_plugin('foo1', fake_plugin) + self.assertTrue(directory.is_loaded()) + class PluginDirectoryTestCase(base.BaseTestCase): diff --git a/releasenotes/notes/add-directory-is-loaded-e9da5b65824dddad.yaml b/releasenotes/notes/add-directory-is-loaded-e9da5b65824dddad.yaml new file mode 100644 index 000000000..0758660a1 --- /dev/null +++ b/releasenotes/notes/add-directory-is-loaded-e9da5b65824dddad.yaml @@ -0,0 +1,5 @@ +--- +features: + - | + Introduced neutron_lib.plugins.directory.is_loaded(). This can be used + in lieu of len(plugins()) or bool(plugins()) or plugins() alone.