fea8bb64ba
This patch builds a small hierarchy of event objects that represent the payload for callback notification events. The overall goal of this work is to begin moving away from the existing unstructured **kwargs passed today and standardize on a common set of event payload objects; the beginning of such contained herein. A PoC/dummy patch for neutron is provided in [1] that exemplifies consumption of the new API by: - Removes neutron.callbacks and moves all uses to neutron_lib.callbacks. - Neutron uses of callbacks for BEFORE_RESPONSE events now use neutron-lib. - Neutron uses of callbacks for ROUTER and PROCESS resource events now use neutron-lib. - Neutron UTs updated to pass with this patch. For existing discussion on this approach please see [2][3]. Co-Authored-By: Armando Migliaccio <armamig@gmail.com> [1] https://review.openstack.org/400404/ [2] https://review.openstack.org/#/c/345718 [3] https://review.openstack.org/#/c/342304 Change-Id: If76457b1f0d5d3479e394d0dba3b22a90928f0f2
63 lines
2.1 KiB
Python
63 lines
2.1 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""
|
|
test_callback_exceptions
|
|
----------------------------------
|
|
|
|
Tests for `neutron_lib.callback.exceptions` module.
|
|
"""
|
|
|
|
import functools
|
|
|
|
import neutron_lib.callbacks.exceptions as ex
|
|
from neutron_lib.tests.unit import test_exceptions
|
|
|
|
|
|
class TestCallbackExceptions(test_exceptions.TestExceptions):
|
|
|
|
def _check_exception(self, exc_class, expected_msg, **kwargs):
|
|
raise_exc_class = functools.partial(test_exceptions._raise, exc_class)
|
|
e = self.assertRaises(exc_class, raise_exc_class, **kwargs)
|
|
self.assertEqual(expected_msg, str(e))
|
|
|
|
def test_invalid(self):
|
|
self._check_exception(
|
|
ex.Invalid,
|
|
"The value 'foo' for bar is not valid.",
|
|
value='foo', element='bar')
|
|
|
|
def test_callback_failure(self):
|
|
self._check_exception(
|
|
ex.CallbackFailure,
|
|
'one',
|
|
errors='one')
|
|
|
|
def test_callback_failure_with_list(self):
|
|
self._check_exception(
|
|
ex.CallbackFailure,
|
|
'1,2,3',
|
|
errors=[1, 2, 3])
|
|
|
|
def test_notification_error(self):
|
|
'''Test that correct message is created for this error class.'''
|
|
error = ex.NotificationError('abc', 'boom')
|
|
self.assertEqual('Callback abc failed with "boom"', str(error))
|
|
|
|
def test_inner_exceptions(self):
|
|
key_err = KeyError()
|
|
n_key_err = ex.NotificationError('cb1', key_err)
|
|
err = ex.CallbackFailure([key_err, n_key_err])
|
|
self.assertEqual([key_err, n_key_err.error], err.inner_exceptions)
|