Update patch set 4

Patch Set 4: Workflow-1

(4 comments)

Patch-set: 4
Reviewer: Gerrit User 16688 <16688@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Workflow=-1, 8d4e773602222687d57530d1bb87f2c234222464
Attention: {"person_ident":"Gerrit User 8655 \u003c8655@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_16688\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 16688 \u003c16688@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_16688\u003e replied on the change"}
This commit is contained in:
Gerrit User 16688 2023-01-05 15:36:47 +00:00 committed by Gerrit Code Review
parent 780cfbf75a
commit 017c418da8
1 changed files with 83 additions and 0 deletions

View File

@ -17,6 +17,23 @@
"revId": "aee09a8a2d8420dce54c76692e8e17d7568bbe40",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "21fe3b24_f41a6ad7",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 16688
},
"writtenOn": "2023-01-05T15:36:47Z",
"side": 1,
"message": "Updating the spec now...",
"revId": "aee09a8a2d8420dce54c76692e8e17d7568bbe40",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -40,6 +57,30 @@
"revId": "aee09a8a2d8420dce54c76692e8e17d7568bbe40",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "48361728_0c80a947",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 4
},
"lineNbr": 8,
"author": {
"id": 16688
},
"writtenOn": "2023-01-05T15:36:47Z",
"side": 1,
"message": "Ups sorry!",
"parentUuid": "b2790b02_f12516a7",
"range": {
"startLine": 8,
"startChar": 0,
"endLine": 8,
"endChar": 55
},
"revId": "aee09a8a2d8420dce54c76692e8e17d7568bbe40",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -152,6 +193,24 @@
"revId": "aee09a8a2d8420dce54c76692e8e17d7568bbe40",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c998edc3_5e0c5cde",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 4
},
"lineNbr": 40,
"author": {
"id": 16688
},
"writtenOn": "2023-01-05T15:36:47Z",
"side": 1,
"message": "For now, I think we should stick to the ovsdb communication agent. We can implement the RPC part (even a new agent) in future releases/RFEs.\n\nSo, if I\u0027m reading you well, the idea is:\n1) To create this OVN agent (generic) with an extensible interface, same as other agents. I was thinking about using the ``agent.agent_extensions_manager.AgentExtensionsManager`` class to implement it, same as in other ML2 agents.\n2) Implement the QoS HWOL feature.\n3) In future releases, move the metadata functionality to this \"OVN agent\".\n\nI\u0027ll push a new PS to portray these ideas.",
"parentUuid": "1f91cad9_2556596d",
"revId": "aee09a8a2d8420dce54c76692e8e17d7568bbe40",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -197,6 +256,30 @@
},
"revId": "aee09a8a2d8420dce54c76692e8e17d7568bbe40",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a1b265d0_d00b885b",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 4
},
"lineNbr": 205,
"author": {
"id": 16688
},
"writtenOn": "2023-01-05T15:36:47Z",
"side": 1,
"message": "You are right on this. The QoS information should be translated to the corresponding logical flows with their own matches and actions. But in this case this is not happening due to limitations in the driver. In order to read the min-bw values (that are not applied on the VF), we need to retrieve the Logical_Switch_Port register",
"parentUuid": "cd3de78f_d3b747f0",
"range": {
"startLine": 205,
"startChar": 0,
"endLine": 205,
"endChar": 57
},
"revId": "aee09a8a2d8420dce54c76692e8e17d7568bbe40",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}