openstack
/
neutron-specs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(4 comments)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 35432 \u003c35432@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35432\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 11975 \u003c11975@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35432\u003e replied on the change"}
This commit is contained in:
Gerrit User 35432 2023-10-30 18:56:34 +00:00 committed by Gerrit Code Review
parent 258223abab
commit 05a5d0ae18
1 changed files with 83 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

83
fd59bc8ded5aa317748af3b9f7be6ba3751f12e6
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "efc06504_ed939020",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 35432
},
"writtenOn": "2023-10-30T18:56:34Z",
"side": 1,
"message": "Thanks for the review :)",
"revId": "fd59bc8ded5aa317748af3b9f7be6ba3751f12e6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -23,6 +40,30 @@
"revId": "fd59bc8ded5aa317748af3b9f7be6ba3751f12e6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "58a77e1b_4ca52f9e",
"filename": "specs/2024.1/l3bgp-resilient-peer-sessions.rst",
"patchSetId": 1
},
"lineNbr": 33,
"author": {
"id": 35432
},
"writtenOn": "2023-10-30T18:56:34Z",
"side": 1,
"message": "I changed the term FSM to \u0027periodic task\u0027 because it seems more in line with the flowchart explanation.",
"parentUuid": "259a9b3d_ad535dda",
"range": {
"startLine": 33,
"startChar": 62,
"endLine": 33,
"endChar": 66
},
"revId": "fd59bc8ded5aa317748af3b9f7be6ba3751f12e6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +87,30 @@
"revId": "fd59bc8ded5aa317748af3b9f7be6ba3751f12e6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1a67dc9d_c470c3b8",
"filename": "specs/2024.1/l3bgp-resilient-peer-sessions.rst",
"patchSetId": 1
},
"lineNbr": 116,
"author": {
"id": 35432
},
"writtenOn": "2023-10-30T18:56:34Z",
"side": 1,
"message": "Makes sense to me, thanks!",
"parentUuid": "e088d331_65035a08",
"range": {
"startLine": 116,
"startChar": 2,
"endLine": 116,
"endChar": 16
},
"revId": "fd59bc8ded5aa317748af3b9f7be6ba3751f12e6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -62,6 +127,24 @@
"message": "sorry, maybe I\u0027m missing something but when after those 3 cases really full sync should be run actually?",
"revId": "fd59bc8ded5aa317748af3b9f7be6ba3751f12e6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "cfa4f73f_c439994a",
"filename": "specs/2024.1/l3bgp-resilient-peer-sessions.rst",
"patchSetId": 1
},
"lineNbr": 165,
"author": {
"id": 35432
},
"writtenOn": "2023-10-30T18:56:34Z",
"side": 1,
"message": "Yeap, definitely yes, I added a new paragraph to make this clear.",
"parentUuid": "655adc5d_0b5395a3",
"revId": "fd59bc8ded5aa317748af3b9f7be6ba3751f12e6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}