Update patch set 8

Patch Set 8: Code-Review+1 (6 comments) Patch-set: 8 Reviewer: Gerrit User 11604 <11604@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+1 Attention: {"person_ident":"Gerrit User 11604 \u003c11604@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change"}
2022-11-14 17:17:32 +00:00 · 2022-11-14 17:17:32 +00:00 · 19d278c01a
parent e3cf4ca58f
commit 19d278c01a
3 changed files with 116 additions and 0 deletions
--- a/24
+++ b/24
@ -272,6 +272,30 @@
      "revId": "09ee72205f522b16261a4ae919e03511386c0e9d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "9b267f2a_4bf817e2",
+        "filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
+        "patchSetId": 6
+      },
+      "lineNbr": 99,
+      "author": {
+        "id": 11604
+      },
+      "writtenOn": "2022-11-14T17:17:32Z",
+      "side": 1,
+      "message": "Ack",
+      "parentUuid": "5762cd5a_f91d3267",
+      "range": {
+        "startLine": 99,
+        "startChar": 1,
+        "endLine": 99,
+        "endChar": 26
+      },
+      "revId": "09ee72205f522b16261a4ae919e03511386c0e9d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
    {
      "unresolved": true,
      "key": {
--- a/74
+++ b/74
@ -16,6 +16,80 @@
      "message": "See my comment below, let\u0027s wait for others votes",
      "revId": "1b2506fea06d524218886ae5079121155a9e51b2",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "004e9ed3_4f7051d0",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 8
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 11604
+      },
+      "writtenOn": "2022-11-14T17:17:32Z",
+      "side": 1,
+      "message": "+1 over all but one comment on the trait that proably shoudl be adressed before this is accepted",
+      "revId": "1b2506fea06d524218886ae5079121155a9e51b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "39b5e4ea_d448821b",
+        "filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
+        "patchSetId": 8
+      },
+      "lineNbr": 124,
+      "author": {
+        "id": 11604
+      },
+      "writtenOn": "2022-11-14T17:17:32Z",
+      "side": 1,
+      "message": "given the intent to keep this minimal and since we are not going to standardise the rest of the trait let defer making this a standard trait for this release.\n\nsed \"s/NETWORK_TUNNEL_PROVIDER/CUSTOM_NETWORK_TUNNEL_PROVIDER/g\"\n\n\nwe can adress this in a sperate spec in the futre that focus on network aware schduleing.\n\ni.e. allowing nova to schdule to host that support the required vnic type, and network type.\n\nso my recomendation is to reduce thet scope fo the spec by using CUSTOM_NETWORK_TUNNEL_PROVIDER for now to avoid change to os-traits\nand we can come back to this in the B/C cycle.",
+      "range": {
+        "startLine": 124,
+        "startChar": 4,
+        "endLine": 124,
+        "endChar": 27
+      },
+      "revId": "1b2506fea06d524218886ae5079121155a9e51b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "83565dec_2f37dbb8",
+        "filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
+        "patchSetId": 8
+      },
+      "lineNbr": 187,
+      "author": {
+        "id": 11604
+      },
+      "writtenOn": "2022-11-14T17:17:32Z",
+      "side": 1,
+      "message": "i spoke to rodolfo about the direction here and i understand more the scope that they want to define for this.\n\n\nwe went over the history a bit and disucssed the current supprot in ml2/ovs and ml2/ovn\n\ntl;dr is for ml2/ovs applying min bandwith QOS policies to neutron network is blocked and ml2/ovn does not currently supprot the min bandwith qos.\n\nthat will change with this spec but we shoudl not have any existign usage of min bandwith qos with tunneled networks. as a result we do not need to provide an automated upgrade proceedure to reshape the allocations of exsiting ports.\n\nwe discussed that there is an existign gap when using min bandwith with phyent backed networks, notably that if you chang the bandwith qos policy config options \ntoday we do not suport reshapes today for the removal or addtion  of bandwith qos inventories if you have pre existing ports that shoudl NET_BW_EGR_KILOBIT_PER_SEC follow an upgrade.\n\nthis spec does not adress that but its not a new problem since it applies to vlan/flat networks today as well. as such i think its reasonable to declare that out of scope of this spec and track it as a bug/future improvment that can be done seperatly.",
+      "revId": "1b2506fea06d524218886ae5079121155a9e51b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "c05933b6_ad6977ec",
+        "filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
+        "patchSetId": 8
+      },
+      "lineNbr": 197,
+      "author": {
+        "id": 11604
+      },
+      "writtenOn": "2022-11-14T17:17:32Z",
+      "side": 1,
+      "message": "one thing we discussed was wether nova\u0027s nova-manage heal-allocations  command might be able to fix things in place. if not that is perhaps an improment we coudl make in the future.\n\nnova would fix the allcoation on a cold/live migrate so that is an option albit a somewhat expensive one to adress this. this supprot was added in ussuri by \nhttps://specs.openstack.org/openstack/nova-specs/specs/ussuri/implemented/support-move-ops-with-qos-ports-ussuri.html\n\na less invaisve change would be to detach and attach the ports with qos policies\nwhich was added in wallaby.\n\nhttps://specs.openstack.org/openstack/nova-specs/specs/wallaby/implemented/support-interface-attach-with-qos-ports.html\n\nthe other option is to just remove teh min bandwith qos policy form the neutron ports before upgrading.\n\ni think documenting these options is likely the minium we need to do to enabel operators to determin the best parth forward for them in the A cycle.",
+      "revId": "1b2506fea06d524218886ae5079121155a9e51b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
 }
--- a/18
+++ b/18
@ -382,6 +382,24 @@
      "message": "i really dont think this is a good upgrade experince.\n\nneutron or nova should be enhanced to do a reshape of the allcotions\n\nneutron coudl do it automatically if it was opted into as a sideefect of defining tunnelled_network_rp_name\n\nto make that wort we shoudl not ahve a default value for tunnelled_network_rp_name",
      "revId": "7fdc74b912aa683acb27532c45a09c93dcf38a4a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "0ff990d2_8a851649",
+        "filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
+        "patchSetId": 7
+      },
+      "lineNbr": 198,
+      "author": {
+        "id": 11604
+      },
+      "writtenOn": "2022-11-14T17:17:32Z",
+      "side": 1,
+      "message": "Ack",
+      "parentUuid": "2efd815a_918ac501",
+      "revId": "7fdc74b912aa683acb27532c45a09c93dcf38a4a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
 }