openstack
/
neutron-specs
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(4 comments)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 8655 \u003c8655@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_6773\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 6773 \u003c6773@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_6773\u003e replied on the change"}
This commit is contained in:
Gerrit User 6773 2023-01-06 11:41:46 +00:00 committed by Gerrit Code Review
parent 2343828ab6
commit 1a0c1de90d
1 changed files with 81 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

81
835b07c55eb3738d12966437cb445d8dd0e024fc
View File

@ -23,6 +23,46 @@
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "251ea3ea_042a236e",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 6773
},
"writtenOn": "2023-01-06T11:41:46Z",
"side": 1,
"message": "Thanks Rodolfo, overall I think this looks good. You may want to fix a few nits in the writing before merging but the essence seems very good.\n\nThank you!",
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1a3e75c7_e5bcc188",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 35,
"author": {
"id": 6773
},
"writtenOn": "2023-01-06T11:41:46Z",
"side": 1,
"message": "OVN Agent ?",
"range": {
"startLine": 35,
"startChar": 66,
"endLine": 35,
"endChar": 77
},
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -137,6 +177,47 @@
},
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1e21687f_b85a611f",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 149,
"author": {
"id": 6773
},
"writtenOn": "2023-01-06T11:41:46Z",
"side": 1,
"message": "From what I understoond, we need to set this \"qos_min_rate\" option in the LSP table for this to work. And, if we are writing that option we need to include the LSP table when we create the connection.\n\nhttps://man7.org/linux/man-pages/man5/ovn-nb.5.html",
"parentUuid": "66323590_ef4a32c2",
"range": {
"startLine": 149,
"startChar": 47,
"endLine": 149,
"endChar": 74
},
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "84165855_19af6471",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 231,
"author": {
"id": 6773
},
"writtenOn": "2023-01-06T11:41:46Z",
"side": 1,
"message": "Maybe u can mention that in the future, as we port the metadata functionality to this new agent this issue could potentially be mitigated because all functionalities will share the same connections.",
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}