openstack
/
neutron-specs
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(2 comments)

Patch-set: 6
Attention: {"person_ident":"Gerrit User 8313 \u003c8313@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 11604 \u003c11604@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change"}
This commit is contained in:
Gerrit User 11604 2022-11-04 09:50:33 +00:00 committed by Gerrit Code Review
parent 9d219ce47b
commit 28145a7534
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
c9a9703febc0f67e23536af42331483c85fb137e
View File

@ -52,6 +52,24 @@
"revId": "c9a9703febc0f67e23536af42331483c85fb137e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "27273954_b9baf604",
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
"patchSetId": 4
},
"lineNbr": 33,
"author": {
"id": 11604
},
"writtenOn": "2022-11-04T09:50:33Z",
"side": 1,
"message": "the minium bandwith qos policy predates the guarneteed strict minium bandiwht feature. it was intoduced in newton https://specs.openstack.org/openstack/neutron-specs/specs/newton/ml2-qos-minimum-egress-bw-support.html that api was intend for use wiht all netowrk backends\n\n\ntunneled support was in the original design requiremnt for the strict/guarenteeed bandwidth feature\n\nhttps://review.opendev.org/c/openstack/neutron-specs/+/396297/7/specs/pike/strict-minimum-bandwidth-support.rst#48\n\n\n\"\"\"\nthe resources will have the following form, please note INGRESS is\nprovided as a reference but it\u0027s out of the scope of this spec:\n NIC_BW_EGRESS.\u003cphysical-network\u003e\n NIC_BW_INGRESS.\u003cphysical-network\u003e\nphysical-network will be the \"physnet\" in the reference implementation,\nor \"tunneling\" in the case of requesting bandwidth on the tunneling\npath.\n\"\"\"\n\nthat comment was filed for this bug which rodolfo created https://bugs.launchpad.net/neutron/+bug/1913180\n\nits not a reflection of the orginal intent just of a limiation in neutron due to an incomplete implementation.\n\nsomewhere between the pike spec and the queens spec https://review.opendev.org/c/openstack/neutron-specs/+/508149/ the refence to tunneling were remvoed but it was never declared out of scope in the spec or on any conversation taht i recall.\n\nso not it was not just ment to work with physnets.",
"parentUuid": "03af39a3_927912c0",
"revId": "c9a9703febc0f67e23536af42331483c85fb137e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -159,6 +177,24 @@
"revId": "c9a9703febc0f67e23536af42331483c85fb137e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7248ea33_685d2544",
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
"patchSetId": 4
},
"lineNbr": 46,
"author": {
"id": 11604
},
"writtenOn": "2022-11-04T09:50:33Z",
"side": 1,
"message": "There is a long history but ooo should implement this today or there was a regression since it was implmented many years ago.\n\nIt was the reference topology we implemented in networking-ovs-dpdk and kolla-ansible when using dpdk.\n\ni belive would be required for hardware offloaded ovs to fully offload tunneled networks in hardware but i have not tested that.",
"parentUuid": "03052501_b4f8f9a6",
"revId": "c9a9703febc0f67e23536af42331483c85fb137e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {