Update patch set 2
Patch Set 2: (1 comment) Patch-set: 2 Attention: {"person_ident":"Gerrit User 5948 \u003c5948@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_15554\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 15554 \u003c15554@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_15554\u003e replied on the change"}
This commit is contained in:
parent
f37cd52d22
commit
2a29a7608f
|
@ -70,6 +70,30 @@
|
|||
},
|
||||
"revId": "0d9d5f84a5efacea47b5c46fa3da3ea7882876d9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "ae8ea622_6cee4686",
|
||||
"filename": "specs/2023.1/ovs-tx-steering.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 63,
|
||||
"author": {
|
||||
"id": 15554
|
||||
},
|
||||
"writtenOn": "2022-11-07T13:25:00Z",
|
||||
"side": 1,
|
||||
"message": "\u003e Do you mean you don\u0027t want to expose those new fields in port GET API response? Why?\n\nThis is not what I meant.\n\n\u003e I mean the one who set those \"hints\" on port creation - how would she/he know if it was applied or not?\n\nI see two possible ways:\n\n1) We introduce another port attribute: hint_status, a dict with keys for the hint aliases and the usual status values, like: BUILD/ACTIVE/ERROR. For example:\n\nport[\"hint_status\"] \u003d {\"ovs-tx-steering\": \"ACTIVE\"}\n\n2) Or that we omit this (hint_status) attribute and don\u0027t give feedback on the API. Then the user would only know about the effect of a hint via ad hoc ways, like the cloud admin communicating/documenting, which hints make sense in a particular deployment.\n\nThe spec currently proposes (2), but I\u0027m also open to (1).",
|
||||
"parentUuid": "854cc137_ede487a0",
|
||||
"range": {
|
||||
"startLine": 59,
|
||||
"startChar": 27,
|
||||
"endLine": 63,
|
||||
"endChar": 73
|
||||
},
|
||||
"revId": "0d9d5f84a5efacea47b5c46fa3da3ea7882876d9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue