Update patch set 3

Patch Set 3:

(2 comments)

Patch-set: 3
This commit is contained in:
Gerrit User 9642 2022-09-15 08:58:55 +00:00 committed by Gerrit Code Review
parent 5a713fd3e8
commit 2db52a782b
1 changed files with 48 additions and 0 deletions

View File

@ -40,6 +40,30 @@
"revId": "964104720cc202a8348757624409bae1c9d98035",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8b5aa33c_64dcd816",
"filename": "specs/2023.1/metadata-rate-limit.rst",
"patchSetId": 3
},
"lineNbr": 25,
"author": {
"id": 9642
},
"writtenOn": "2022-09-15T08:58:55Z",
"side": 1,
"message": "I think so, at least in theory. In practice, if end-users cannot forge the source-IP of their instance in a way that the metadata can answer to, they\u0027ll need the assistance of the control plane to get more source IPs in order to effectively DDoS metadata.\nFrom what we have seen, end-users are generally not trying to cause harm when they query metadata 10 times a second; they usually don\u0027t even realize they do it.\n\nThat said, the load caused by all the metadata queries over the whole region are also a concern to us, even after accounting for the rate-limiting we are discussing. It would be nice to discuss mitigation of issues like the thundering herd problem, but I feel this should be done through another RFE.",
"parentUuid": "4323913b_e9fb01f7",
"range": {
"startLine": 25,
"startChar": 2,
"endLine": 25,
"endChar": 46
},
"revId": "964104720cc202a8348757624409bae1c9d98035",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -62,6 +86,30 @@
},
"revId": "964104720cc202a8348757624409bae1c9d98035",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d47fdd6a_ea4c5921",
"filename": "specs/2023.1/metadata-rate-limit.rst",
"patchSetId": 3
},
"lineNbr": 61,
"author": {
"id": 9642
},
"writtenOn": "2022-09-15T08:58:55Z",
"side": 1,
"message": "Done",
"parentUuid": "85b165fb_6a99e7e0",
"range": {
"startLine": 61,
"startChar": 50,
"endLine": 61,
"endChar": 59
},
"revId": "964104720cc202a8348757624409bae1c9d98035",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}