Update patch set 5

Patch Set 5:

(5 comments)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 8655 \u003c8655@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8655\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 16688 \u003c16688@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8655\u003e replied on the change"}
This commit is contained in:
Gerrit User 8655 2023-01-05 18:20:26 +00:00 committed by Gerrit Code Review
parent b168b5a787
commit 3cd6ff4709
1 changed files with 119 additions and 0 deletions

View File

@ -0,0 +1,119 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "a7e36104_aa487288",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 44,
"author": {
"id": 8655
},
"writtenOn": "2023-01-05T18:20:26Z",
"side": 1,
"message": "nit: I would call it \"Neutron-OVN agent\" or \"OVN-Neutron agent\" to avoid ambiguity that it might belong to the OVN project.",
"range": {
"startLine": 44,
"startChar": 22,
"endLine": 44,
"endChar": 31
},
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "fa86175c_16ca447b",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 50,
"author": {
"id": 8655
},
"writtenOn": "2023-01-05T18:20:26Z",
"side": 1,
"message": "nit: Unlike ?",
"range": {
"startLine": 50,
"startChar": 0,
"endLine": 50,
"endChar": 6
},
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "070d498e_cab18295",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 68,
"author": {
"id": 8655
},
"writtenOn": "2023-01-05T18:20:26Z",
"side": 1,
"message": "A note unrelated to this proposal to get feedback from knowledgable people: This is gonna change the number of connections at scale drastically. I\u0027m not familiar much with Telco edge sites but I assume they can have hundreds of HWOL enabled nodes to host VNFs. Maybe someone with better edge knowledge than mine can chime in to discuss what numbers do we plan to work with. We will need to document this architectural change for scale environments.",
"range": {
"startLine": 68,
"startChar": 52,
"endLine": 68,
"endChar": 66
},
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "09857d57_0d60fe48",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 134,
"author": {
"id": 8655
},
"writtenOn": "2023-01-05T18:20:26Z",
"side": 1,
"message": "bandwidth ? Or rather \"stored in QoS table in bandwidth:rate column key\"",
"range": {
"startLine": 134,
"startChar": 72,
"endLine": 134,
"endChar": 76
},
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "66323590_ef4a32c2",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 149,
"author": {
"id": 8655
},
"writtenOn": "2023-01-05T18:20:26Z",
"side": 1,
"message": "Idea: The QoS table is a lot smaller than LSP table. I\u0027m wondering if it\u0027s worth to monitor LSP table just to obtain the qos_min_rate value as this table can be in a number of tens of thousand of entries. If we, by the ovn mech driver, store this value as an external id in the QoS table along with LSP options then perhaps we can avoid having to monitor the LSP table completel?",
"range": {
"startLine": 149,
"startChar": 47,
"endLine": 149,
"endChar": 74
},
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}