Update patch set 1
Patch Set 1: (10 comments) Patch-set: 1 CC: Gerrit User 16688 <16688@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 16688
Gerrit Code Review
parent
e94606d073
commit
40bc0a103a
|
|
@ -22,6 +22,236 @@
|
|||
},
|
||||
"revId": "f8e89a53f35fd4232cac7befbf4b370f52258d5a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c6f85c5c_92184d37",
|
||||
"filename": "specs/xena/flow-based-dvr-l3.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 11,
|
||||
"author": {
|
||||
"id": 16688
|
||||
},
|
||||
"writtenOn": "2022-10-20T09:51:34Z",
|
||||
"side": 1,
|
||||
"message": "Please, add the correct link",
|
||||
"range": {
|
||||
"startLine": 11,
|
||||
"startChar": 0,
|
||||
"endLine": 11,
|
||||
"endChar": 15
|
||||
},
|
||||
"revId": "f8e89a53f35fd4232cac7befbf4b370f52258d5a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "11d376d4_5360a11b",
|
||||
"filename": "specs/xena/flow-based-dvr-l3.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 21,
|
||||
"author": {
|
||||
"id": 16688
|
||||
},
|
||||
"writtenOn": "2022-10-20T09:51:34Z",
|
||||
"side": 1,
|
||||
"message": "Focus on the issue here, that is that the L3 routing is done in the kernel, via iptables. So you can summarize this saying this: \"In the ML2/OVN DVR implementation, the L3 routing is executed in the kernel, using iptables. That means the OpenFlow datapath is broken before the packet is delivered to the network interface. The performance degradation affects specially to OVS-DPDK\".",
|
||||
"range": {
|
||||
"startLine": 16,
|
||||
"startChar": 0,
|
||||
"endLine": 21,
|
||||
"endChar": 29
|
||||
},
|
||||
"revId": "f8e89a53f35fd4232cac7befbf4b370f52258d5a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "ae15e387_7d68d6d2",
|
||||
"filename": "specs/xena/flow-based-dvr-l3.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 47,
|
||||
"author": {
|
||||
"id": 16688
|
||||
},
|
||||
"writtenOn": "2022-10-20T09:51:34Z",
|
||||
"side": 1,
|
||||
"message": "Is it mandatory to use \"openvswitch\"? Could be used with \"noop\"?",
|
||||
"range": {
|
||||
"startLine": 47,
|
||||
"startChar": 0,
|
||||
"endLine": 47,
|
||||
"endChar": 4
|
||||
},
|
||||
"revId": "f8e89a53f35fd4232cac7befbf4b370f52258d5a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "f8b534c1_1749370c",
|
||||
"filename": "specs/xena/flow-based-dvr-l3.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 61,
|
||||
"author": {
|
||||
"id": 16688
|
||||
},
|
||||
"writtenOn": "2022-10-20T09:51:34Z",
|
||||
"side": 1,
|
||||
"message": "Instead of VIMP, I would used the term \"FIXEDIP\", that is commonly used in Neutron to refer to a local IP in a private network.",
|
||||
"range": {
|
||||
"startLine": 61,
|
||||
"startChar": 10,
|
||||
"endLine": 61,
|
||||
"endChar": 14
|
||||
},
|
||||
"revId": "f8e89a53f35fd4232cac7befbf4b370f52258d5a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "19146505_6270b933",
|
||||
"filename": "specs/xena/flow-based-dvr-l3.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 78,
|
||||
"author": {
|
||||
"id": 16688
|
||||
},
|
||||
"writtenOn": "2022-10-20T09:51:34Z",
|
||||
"side": 1,
|
||||
"message": "The local router IP?",
|
||||
"range": {
|
||||
"startLine": 78,
|
||||
"startChar": 62,
|
||||
"endLine": 78,
|
||||
"endChar": 73
|
||||
},
|
||||
"revId": "f8e89a53f35fd4232cac7befbf4b370f52258d5a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "b093b99a_a671d817",
|
||||
"filename": "specs/xena/flow-based-dvr-l3.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 80,
|
||||
"author": {
|
||||
"id": 16688
|
||||
},
|
||||
"writtenOn": "2022-10-20T09:51:34Z",
|
||||
"side": 1,
|
||||
"message": "Sorry, what does it mean?",
|
||||
"range": {
|
||||
"startLine": 80,
|
||||
"startChar": 3,
|
||||
"endLine": 80,
|
||||
"endChar": 57
|
||||
},
|
||||
"revId": "f8e89a53f35fd4232cac7befbf4b370f52258d5a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "fea60186_02bf14a3",
|
||||
"filename": "specs/xena/flow-based-dvr-l3.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 86,
|
||||
"author": {
|
||||
"id": 16688
|
||||
},
|
||||
"writtenOn": "2022-10-20T09:51:34Z",
|
||||
"side": 1,
|
||||
"message": "What ARP requests? For the FIPs? For the local router IP?",
|
||||
"range": {
|
||||
"startLine": 86,
|
||||
"startChar": 9,
|
||||
"endLine": 86,
|
||||
"endChar": 20
|
||||
},
|
||||
"revId": "f8e89a53f35fd4232cac7befbf4b370f52258d5a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "d78671c2_61fc1121",
|
||||
"filename": "specs/xena/flow-based-dvr-l3.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 92,
|
||||
"author": {
|
||||
"id": 16688
|
||||
},
|
||||
"writtenOn": "2022-10-20T09:51:34Z",
|
||||
"side": 1,
|
||||
"message": "For the local FIPs, right? It is better to specify it",
|
||||
"range": {
|
||||
"startLine": 92,
|
||||
"startChar": 3,
|
||||
"endLine": 92,
|
||||
"endChar": 46
|
||||
},
|
||||
"revId": "f8e89a53f35fd4232cac7befbf4b370f52258d5a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e4e424e3_9b0733d5",
|
||||
"filename": "specs/xena/flow-based-dvr-l3.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 131,
|
||||
"author": {
|
||||
"id": 16688
|
||||
},
|
||||
"writtenOn": "2022-10-20T09:51:34Z",
|
||||
"side": 1,
|
||||
"message": "This section (and the next one) is describing the POC you probably have. But this is not necessary. What we need to have in a spec is a description of *what* are you going to do, not *how* in the code. What I was expecting from this spec:\n- An overall description of the feature.\n- A description of the type of flows/traffic types that will be affected (ARPs, ICMP, etc). That is done but in different sections.\n- Also could be fine to have a graph of the flow of these traffic types.\n\nWe don\u0027t need here what new methods are going to be added and their descriptions.",
|
||||
"range": {
|
||||
"startLine": 131,
|
||||
"startChar": 0,
|
||||
"endLine": 131,
|
||||
"endChar": 29
|
||||
},
|
||||
"revId": "f8e89a53f35fd4232cac7befbf4b370f52258d5a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "d966aa41_617620b2",
|
||||
"filename": "specs/xena/flow-based-dvr-l3.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 142,
|
||||
"author": {
|
||||
"id": 16688
|
||||
},
|
||||
"writtenOn": "2022-10-20T09:51:34Z",
|
||||
"side": 1,
|
||||
"message": "Why are you still using namespaces?",
|
||||
"range": {
|
||||
"startLine": 142,
|
||||
"startChar": 43,
|
||||
"endLine": 142,
|
||||
"endChar": 56
|
||||
},
|
||||
"revId": "f8e89a53f35fd4232cac7befbf4b370f52258d5a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue