openstack
/
neutron-specs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: I would prefer that you didn't merge this

(2 inline comments)



Patch-set: 1
Label: Code-Review=-1
Label: Workflow=0
This commit is contained in:
Gerrit User 105 2014-04-17 18:42:10 +00:00 committed by Gerrit Code Review
parent 4e8415b887
commit 41ced5d3e2
1 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
31ffc682f64125f8639ae6d59632b4693779b590
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"key": {
"uuid": "AAAAXH//wzQ\u003d",
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
"patchSetId": 1
},
"lineNbr": 13,
"author": {
"id": 105
},
"writtenOn": "2014-04-17T18:42:10Z",
"side": 1,
"message": "Nit: There is whitespace in various places here, can you please clean that up?",
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//wQc\u003d",
@ -17,6 +34,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//vyQ\u003d",
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
"patchSetId": 1
},
"lineNbr": 21,
"author": {
"id": 105
},
"writtenOn": "2014-04-17T18:42:10Z",
"side": 1,
"message": "This picture doesn\u0027t line up nicely in the review. Did you try using asciiflow.com and pasting the result in here? That may work better.",
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//wRk\u003d",