Update patch set 10
Patch Set 10: Code-Review+1 (3 comments) Patch-set: 10 Reviewer: Gerrit User 9708 <9708@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+1 Attention: {"person_ident":"Gerrit User 9708 \u003c9708@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9708\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 16688 \u003c16688@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9708\u003e replied on the change"}
This commit is contained in:
parent
6ec47f4504
commit
4ee28263cb
|
@ -0,0 +1,55 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "df020697_c081ff9a",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 9708
|
||||
},
|
||||
"writtenOn": "2022-11-15T16:26:03Z",
|
||||
"side": 1,
|
||||
"message": "The placement modeling looks OK to me as well as the resource_request. Nova should be able to handle that transparently. (If not then I would consider that as a bug on nova side). I\u0027m not super happy about the fact that we ignore the upgrade impact but I guess I\u0027m alone in that so I won\u0027t try to block on that.\n\n",
|
||||
"revId": "5c12c2b8b85aec899904defe43784367c11f5a46",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "4a3bc969_ad410735",
|
||||
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 150,
|
||||
"author": {
|
||||
"id": 9708
|
||||
},
|
||||
"writtenOn": "2022-11-15T16:26:03Z",
|
||||
"side": 1,
|
||||
"message": "Thanks. This is now stated explicitly so it is OK to me.",
|
||||
"revId": "5c12c2b8b85aec899904defe43784367c11f5a46",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "bc9ae3cf_66209468",
|
||||
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 205,
|
||||
"author": {
|
||||
"id": 9708
|
||||
},
|
||||
"writtenOn": "2022-11-15T16:26:03Z",
|
||||
"side": 1,
|
||||
"message": "This is pretty unfortunate. This means that on that host the resource tracking will be incorrect.\n\nI do believe that nova-manage placement heal_allocations could be used for this with limited extra effort.",
|
||||
"revId": "5c12c2b8b85aec899904defe43784367c11f5a46",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue