openstack
/
neutron-specs
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(12 comments)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 16688 \u003c16688@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_16688\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 15554 \u003c15554@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_16688\u003e replied on the change"}
This commit is contained in:
Gerrit User 16688 2023-01-11 17:30:14 +00:00 committed by Gerrit Code Review
parent f774a0bec9
commit 5f99dcabdd
1 changed files with 264 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

264
835b07c55eb3738d12966437cb445d8dd0e024fc
View File

@ -23,6 +23,30 @@
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c7b62558_5ddad1ab",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 7,
"author": {
"id": 16688
},
"writtenOn": "2023-01-11T17:30:14Z",
"side": 1,
"message": "Done",
"parentUuid": "29ec251e_8be4176a",
"range": {
"startLine": 7,
"startChar": 4,
"endLine": 7,
"endChar": 11
},
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -74,6 +98,24 @@
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6d47ab21_b877dacd",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 26,
"author": {
"id": 16688
},
"writtenOn": "2023-01-11T17:30:14Z",
"side": 1,
"message": "You are right on this. I need to include a reference to the OVN agent tracking method.",
"parentUuid": "1e4c5aa2_deeb2725",
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -97,6 +139,30 @@
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0119245d_82e67e27",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 35,
"author": {
"id": 16688
},
"writtenOn": "2023-01-11T17:30:14Z",
"side": 1,
"message": "Done",
"parentUuid": "1a3e75c7_e5bcc188",
"range": {
"startLine": 35,
"startChar": 66,
"endLine": 35,
"endChar": 77
},
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -114,6 +180,24 @@
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9c19c937_a5823131",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 37,
"author": {
"id": 16688
},
"writtenOn": "2023-01-11T17:30:14Z",
"side": 1,
"message": "Done",
"parentUuid": "e2920da0_6471cc51",
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -161,6 +245,30 @@
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1365ac9d_308758a1",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 44,
"author": {
"id": 16688
},
"writtenOn": "2023-01-11T17:30:14Z",
"side": 1,
"message": "Done",
"parentUuid": "a5d9e87e_03c70d5d",
"range": {
"startLine": 44,
"startChar": 22,
"endLine": 44,
"endChar": 31
},
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -184,6 +292,30 @@
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "24abe975_4a2425df",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 50,
"author": {
"id": 16688
},
"writtenOn": "2023-01-11T17:30:14Z",
"side": 1,
"message": "(I\u0027m still making these mistakes...)",
"parentUuid": "fa86175c_16ca447b",
"range": {
"startLine": 50,
"startChar": 0,
"endLine": 50,
"endChar": 6
},
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -207,6 +339,30 @@
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0a3a10c0_92fe2e67",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 54,
"author": {
"id": 16688
},
"writtenOn": "2023-01-11T17:30:14Z",
"side": 1,
"message": "Done",
"parentUuid": "41ace1ee_2593a161",
"range": {
"startLine": 53,
"startChar": 59,
"endLine": 54,
"endChar": 24
},
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -230,6 +386,30 @@
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ed3231a5_6a2f337d",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 68,
"author": {
"id": 16688
},
"writtenOn": "2023-01-11T17:30:14Z",
"side": 1,
"message": "There is always a balance between the new functionality and the scale. If they want to have QoS with HWOL, then they will need to use this new agent, increasing the DB connections.\n\nI\u0027ll say that since [1], we can reduce to 1 the number of SB connections per OVN metadata agent. When moving the metadata functionality to this monitor, we\u0027ll have just one single NB and one SB connections to the database.\n\n[1]https://review.opendev.org/c/openstack/neutron/+/861751",
"parentUuid": "070d498e_cab18295",
"range": {
"startLine": 68,
"startChar": 52,
"endLine": 68,
"endChar": 66
},
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -253,6 +433,30 @@
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "13a20e78_81ae4351",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 134,
"author": {
"id": 16688
},
"writtenOn": "2023-01-11T17:30:14Z",
"side": 1,
"message": "Right, QoS:bandwidth",
"parentUuid": "09857d57_0d60fe48",
"range": {
"startLine": 134,
"startChar": 72,
"endLine": 134,
"endChar": 76
},
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -324,6 +528,30 @@
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f941978e_354ac1c4",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 149,
"author": {
"id": 16688
},
"writtenOn": "2023-01-11T17:30:14Z",
"side": 1,
"message": "In OVN we have two types of QoS BW enforcement: using the kernel classes (linux \"tc\") or metering (NOTE1):\n* max and burst use metering\n* min uses linux traffic control (see [1])\n\nQoS registers are translated into meter rules; LSP.options are used to set the interface TC settings. We can\u0027t use the QoS registers for the min-bw rules.\n\nFor now I\u0027ll keep using the LSP registers but it will be necessary to investigate a future improvement not to use them.\n\nAs Lucas suggested, I\u0027ll add this information to the \"Performance Impact\" section too.\n\nNOTE1: if you check link [0], you\u0027ll see the metering feature has been implemented for mlnx cards. This is for connectx6 NICs, not connect5. But this is not solving the issue of the minimum BW feature, that is not implemented using metering (max and burst are) but using the linux traffic control implementation (HTB classful algorithm).\n\n[0]https://bugzilla.redhat.com/show_bug.cgi?id\u003d2002406\n[1]https://github.com/ovn-org/ovn/commit/dbf12e5fe1f7ab2acef4152854c239b999b70188#diff-538df8a7fc4aa894586caf2191217e5d8a50bf245ee88faf90516a1c229cf42aR6347",
"parentUuid": "8b5311af_caef2835",
"range": {
"startLine": 149,
"startChar": 47,
"endLine": 149,
"endChar": 74
},
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -341,6 +569,24 @@
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "cbbe7620_df91f8d4",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 198,
"author": {
"id": 16688
},
"writtenOn": "2023-01-11T17:30:14Z",
"side": 1,
"message": "You are right. Please check [1]. When the agent is restarted and the DB retrieved, the IDL connection will issue a \"create\" event for each \"Interface\" in the DB. The QoS for these ports will be set in L49.\n\n[1]https://review.opendev.org/c/openstack/neutron/+/866480/11/neutron/agent/ovn/monitor/agent.py#48",
"parentUuid": "d6a652d6_b4277b11",
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -357,6 +603,24 @@
"message": "Maybe u can mention that in the future, as we port the metadata functionality to this new agent this issue could potentially be mitigated because all functionalities will share the same connections.",
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3b71c61c_95c70009",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 5
},
"lineNbr": 231,
"author": {
"id": 16688
},
"writtenOn": "2023-01-11T17:30:14Z",
"side": 1,
"message": "Exactly.",
"parentUuid": "84165855_19af6471",
"revId": "835b07c55eb3738d12966437cb445d8dd0e024fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}