Update patch set 3

Patch Set 3: I would prefer that you didn't merge this

(1 inline comment)

This is very close Nachi! Once more small wording change and a fixup of a > 80 character line.

One note: I don't think this can merge now until we merge a spec since it won't pass the Jenkins job ... due to no spec being in there! If that's a problem, I'll propose a patch with a fake temporary spec to get Jenkins to pass and remove it later.

Patch-set: 3
Label: Code-Review=-1
Label: Workflow=0
This commit is contained in:
Gerrit User 105 2014-04-17 21:01:50 +00:00 committed by Gerrit Code Review
parent da03bf6f7a
commit 606f6555a0
1 changed files with 21 additions and 0 deletions

View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "AAAAXH//uwI\u003d",
"filename": "specs/template.rst",
"patchSetId": 3
},
"lineNbr": 36,
"author": {
"id": 105
},
"writtenOn": "2014-04-17T21:01:50Z",
"side": 1,
"message": "Can you reformulate this to break at 80 lines instead of a single string as it is now? Also, slight wording change. Can you change \"But\" to \"However,\"? Notice the comma as well.",
"revId": "4f0c0e2c0c775c1a62385866879a1b7ada0a4d96",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}