diff --git a/5d72a935a960bf1106b863af6a392162a5b4b212 b/5d72a935a960bf1106b863af6a392162a5b4b212 index 1e4308bbd..2e414114f 100644 --- a/5d72a935a960bf1106b863af6a392162a5b4b212 +++ b/5d72a935a960bf1106b863af6a392162a5b4b212 @@ -221,6 +221,30 @@ }, "revId": "5d72a935a960bf1106b863af6a392162a5b4b212", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "f53be410_4d818b82", + "filename": "specs/2023.2/active-active-l3-gateway-with-multihoming.rst", + "patchSetId": 6 + }, + "lineNbr": 216, + "author": { + "id": 11975 + }, + "writtenOn": "2023-03-23T16:27:59Z", + "side": 1, + "message": "I think it also could be race prone and if 2 clients would make requests updating this field it could be not updated properly. We have seen similar issue with extra routes field.", + "parentUuid": "f1d8e68b_50510a6b", + "range": { + "startLine": 214, + "startChar": 0, + "endLine": 216, + "endChar": 42 + }, + "revId": "5d72a935a960bf1106b863af6a392162a5b4b212", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file diff --git a/c7600fbd8cb931a1ad04bf33431c3c133b603bda b/c7600fbd8cb931a1ad04bf33431c3c133b603bda new file mode 100644 index 000000000..436fd818b --- /dev/null +++ b/c7600fbd8cb931a1ad04bf33431c3c133b603bda @@ -0,0 +1,61 @@ +{ + "comments": [ + { + "unresolved": true, + "key": { + "uuid": "6069b858_bcf0bb89", + "filename": "specs/2023.2/active-active-l3-gateway-with-multihoming.rst", + "patchSetId": 8 + }, + "lineNbr": 212, + "author": { + "id": 11975 + }, + "writtenOn": "2023-03-23T16:27:59Z", + "side": 1, + "message": "I\u0027m not sure I understand correctly. So if user will update router and set current field \"external_gateway_info\" to be empty, Neutron will remove that gateway_info from the new \"external_gateways\" list (element 0 in that list) and set new element \"0\" as \"external_gateway_info\". Correct?", + "revId": "c7600fbd8cb931a1ad04bf33431c3c133b603bda", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "397d085b_dee2f87b", + "filename": "specs/2023.2/active-active-l3-gateway-with-multihoming.rst", + "patchSetId": 8 + }, + "lineNbr": 234, + "author": { + "id": 11975 + }, + "writtenOn": "2023-03-23T16:27:59Z", + "side": 1, + "message": "is this really necessary? Shouldn\u0027t add and remove be enough?", + "revId": "c7600fbd8cb931a1ad04bf33431c3c133b603bda", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "52135f1f_9d1f3ca5", + "filename": "specs/2023.2/active-active-l3-gateway-with-multihoming.rst", + "patchSetId": 8 + }, + "lineNbr": 263, + "author": { + "id": 11975 + }, + "writtenOn": "2023-03-23T16:27:59Z", + "side": 1, + "message": "nitty nit: should start with lowercase", + "range": { + "startLine": 263, + "startChar": 11, + "endLine": 263, + "endChar": 18 + }, + "revId": "c7600fbd8cb931a1ad04bf33431c3c133b603bda", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + } + ] +} \ No newline at end of file