Update patch set 6
Patch Set 6: Code-Review-1 (3 comments) Patch-set: 6 Reviewer: Gerrit User 4694 <4694@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1 Attention: {"person_ident":"Gerrit User 33525 \u003c33525@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4694\u003e replied on the change"}
This commit is contained in:
parent
cd12fce2b4
commit
841068ef33
|
@ -16,6 +16,75 @@
|
|||
"message": "Oops! I\u0027ve corrected it to `firewall_groups` -- Thanks!",
|
||||
"revId": "53e0bbaaffa257991dd82523496ed252463e4f66",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "72ab2342_1e405c9c",
|
||||
"filename": "specs/zed/fwaas-group-ordering.rst",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 21,
|
||||
"author": {
|
||||
"id": 4694
|
||||
},
|
||||
"writtenOn": "2022-08-19T21:13:51Z",
|
||||
"side": 1,
|
||||
"message": "The linked RFE contains a lot of stuff. Would you please state explicitly the problem this spec addresses?",
|
||||
"range": {
|
||||
"startLine": 21,
|
||||
"startChar": 0,
|
||||
"endLine": 21,
|
||||
"endChar": 24
|
||||
},
|
||||
"revId": "53e0bbaaffa257991dd82523496ed252463e4f66",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "f35b7c2d_4f6c0586",
|
||||
"filename": "specs/zed/fwaas-group-ordering.rst",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 37,
|
||||
"author": {
|
||||
"id": 4694
|
||||
},
|
||||
"writtenOn": "2022-08-19T21:13:51Z",
|
||||
"side": 1,
|
||||
"message": "Does this mean users with the \u0027admin\u0027 role? This aspect of OpenStack has become pretty complicated in recent cycles",
|
||||
"range": {
|
||||
"startLine": 37,
|
||||
"startChar": 10,
|
||||
"endLine": 37,
|
||||
"endChar": 25
|
||||
},
|
||||
"revId": "53e0bbaaffa257991dd82523496ed252463e4f66",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "7f60817a_8ffc024d",
|
||||
"filename": "specs/zed/fwaas-group-ordering.rst",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 147,
|
||||
"author": {
|
||||
"id": 4694
|
||||
},
|
||||
"writtenOn": "2022-08-19T21:13:51Z",
|
||||
"side": 1,
|
||||
"message": "The rendition of this in the final document is unreadable: https://8c06a6cede9420c6761b-340bd32e45a22d1b24bb452a4a4f9f06.ssl.cf5.rackcdn.com/851607/6/check/openstack-tox-docs/baa2987/docs/specs/zed/fwaas-group-ordering.html#data-model-impact/ I suggest you place this inside a code-block directive. For example, look how the output of the openstack command in this section\n\nCreate a routed provider network\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nThe following steps create a routed provider network with two segments. Each\nsegment contains one IPv4 subnet and one IPv6 subnet.\n\n#. Source the administrative project credentials.\n#. Create a VLAN provider network which includes a default segment. In this\n example, the network uses the ``provider1`` physical network with VLAN ID\n 2016.\n\n .. code-block:: console\n\n $ openstack network create --share --provider-physical-network provider1 \\\n --provider-network-type vlan --provider-segment 2016 multisegment1\n +---------------------------+--------------------------------------+\n | Field | Value |\n +---------------------------+--------------------------------------+\n | admin_state_up | UP |\n | id | 6ab19caa-dda9-4b3d-abc4-5b8f435b98d9 |\n | ipv4_address_scope | None |\n | ipv6_address_scope | None |\n | l2_adjacency | True |\n | mtu | 1500 |\n | name | multisegment1 |\n | port_security_enabled | True |\n | provider:network_type | vlan |\n | provider:physical_network | provider1 |\n | provider:segmentation_id | 2016 |\n | revision_number | 1 |\n | router:external | Internal |\n | shared | True |\n | status | ACTIVE |\n | subnets | |\n | tags | [] |\n +---------------------------+--------------------------------------+\n\n\nis rendered here: https://github.com/openstack/neutron/blob/master/doc/source/admin/config-routed-networks.rst#create-a-routed-provider-network",
|
||||
"range": {
|
||||
"startLine": 138,
|
||||
"startChar": 0,
|
||||
"endLine": 147,
|
||||
"endChar": 0
|
||||
},
|
||||
"revId": "53e0bbaaffa257991dd82523496ed252463e4f66",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue