From 8a524f54c7a73b35076b2dd6d003e897f14c7635 Mon Sep 17 00:00:00 2001 From: Kyle Mestery Date: Tue, 23 Sep 2014 15:23:51 +0000 Subject: [PATCH] Reformat template.rst. Change the layout of this file to move the formatting examples to the bottom to move clearly highlight the operator requirements section at the top. Also update the test infrastructure to reflect the changes, and also only run unit tests on the kilo specs. Change-Id: Ie5e0c2779e69585c1800d6ecaf9062f3d2d81cbb --- specs/skeleton.rst | 48 +++- specs/template.rst | 664 +++++++++++++++++++++++-------------------- tests/test_titles.py | 32 ++- 3 files changed, 409 insertions(+), 335 deletions(-) diff --git a/specs/skeleton.rst b/specs/skeleton.rst index ba77613de..6cc37b617 100644 --- a/specs/skeleton.rst +++ b/specs/skeleton.rst @@ -9,35 +9,31 @@ Title of your blueprint ========================================== -Problem description +Problem Description =================== -Proposed change +Proposed Change =============== -Alternatives ------------- - - -Data model impact +Data Model Impact ----------------- -REST API impact +REST API Impact --------------- -Security impact +Security Impact --------------- -Notifications impact +Notifications Impact -------------------- -Other end user impact +Other End User Impact --------------------- @@ -45,14 +41,22 @@ Performance Impact ------------------ -Other deployer impact +Other Deployer Impact --------------------- -Developer impact +Developer Impact ---------------- +Community Impact +---------------- + + +Alternatives +------------ + + Implementation ============== @@ -71,10 +75,28 @@ Dependencies Testing ======= +Tempest Tests +------------- + + +Functional Tests +---------------- + + +API Tests +--------- + Documentation Impact ==================== +User Documentation +------------------ + + +Developer Documentation +----------------------- + References ========== diff --git a/specs/template.rst b/specs/template.rst index 9d4b06646..5f21c494c 100644 --- a/specs/template.rst +++ b/specs/template.rst @@ -13,7 +13,361 @@ Include the URL of your launchpad blueprint: https://blueprints.launchpad.net/neutron/+spec/example Introduction paragraph -- why are we doing anything? A single paragraph of -prose that operators can understand. +prose that **operators, deployers, and developers** can understand. + +Problem Description +=================== + +A detailed description of the problem: + +* For a new feature this should be use cases. Ensure you are clear about the + actors in each use case: End User vs Deployer + +* For a major reworking of something existing it would describe the + problems in that feature that are being addressed. + + +Proposed Change +=============== + +Here is where you cover the change you propose to make in detail. How do you +propose to solve this problem? + +If this is one part of a larger effort make it clear where this piece ends. In +other words, what's the scope of this effort? + +Data Model Impact +----------------- + +Changes which require modifications to the data model often have a wider impact +on the system. The community often has strong opinions on how the data model +should be evolved, from both a functional and performance perspective. It is +therefore important to capture and gain agreement as early as possible on any +proposed changes to the data model. + +Questions which need to be addressed by this section include: + +* What new data objects and/or database schema changes is this going to require? + +* What database migrations will accompany this change. + +* How will the initial set of new data objects be generated, for example if you + need to take into account existing instances, or modify other existing data + describe how that will work. + +REST API Impact +--------------- + +For each API resource to be implemented using Neutron's attribute map +facility (see the neutron.api.v2.attributes), describe the resource +collection and specify the name, type, and other essential details of +each new or modified attribute. A table similar to the following may +be used: + ++----------+-------+---------+---------+------------+--------------+ +|Attribute |Type |Access |Default |Validation/ |Description | +|Name | | |Value |Conversion | | ++==========+=======+=========+=========+============+==============+ +|id |string |RO, all |generated|N/A |identity | +| |(UUID) | | | | | ++----------+-------+---------+---------+------------+--------------+ +|name |string |RW, all |'' |string |human-readable| +| | | | | |name | ++----------+-------+---------+---------+------------+--------------+ +|color |string |RW, admin|'red' |'red', |color | +| | | | |'yellow', or|indicating | +| | | | |'green' |state | ++----------+-------+---------+---------+------------+--------------+ + + +Here is the other example of the table using csv-table + + +.. csv-table:: CSVTable + :header: Attribute Name,Type,Access,Default Value,Validation Conversion,Description + + id,string (UUID),"RO, all",generated,N/A,identity + name,string,"RW, all","''",string,human-readable name + color,string,"RW, admin",red,"'red', 'yellow' or 'green'",color indicating state + + +Each API method which is either added or changed that does not use +Neutron's attribute map facility should have the following: + +* Specification for the method + + * A description of what the method does suitable for use in + user documentation + + * Method type (POST/PUT/GET/DELETE) + + * Normal http response code(s) + + * Expected error http response code(s) + + * A description for each possible error code should be included + describing semantic errors which can cause it such as + inconsistent parameters supplied to the method, or when an + instance is not in an appropriate state for the request to + succeed. Errors caused by syntactic problems covered by the JSON + schema defintion do not need to be included. + + * URL for the resource + + * Parameters which can be passed via the url + + * JSON schema definition for the body data if allowed + + * JSON schema definition for the response data if any + +* Example use case including typical API samples for both data supplied + by the caller and the response + +* Discuss any API policy changes, and discuss what things a deployer needs to + think about when defining their API policy. This is in reference to the + policy.json file. + +Note that the schema should be defined as restrictively as +possible. Parameters which are required should be marked as such and +only under exceptional circumstances should additional parameters +which are not defined in the schema be permitted (eg +additionaProperties should be False). + +Reuse of existing predefined parameter types such as regexps for +passwords and user defined names is highly encouraged. + +Security Impact +--------------- + +Describe any potential security impact on the system. Some of the items to +consider include: + +* Does this change touch sensitive data such as tokens, keys, or user data? + +* Does this change alter the API in a way that may impact security, such as + a new way to access sensitive information or a new way to login? + +* Does this change involve cryptography or hashing? + +* Does this change require the use of sudo or any elevated privileges? + +* Does this change involve using or parsing user-provided data? This could + be directly at the API level or indirectly such as changes to a cache layer. + +* Can this change enable a resource exhaustion attack, such as allowing a + single API interaction to consume significant server resources? Some examples + of this include launching subprocesses for each connection, or entity + expansion attacks in XML. + +For more detailed guidance, please see the OpenStack Security Guidelines as +a reference (https://wiki.openstack.org/wiki/Security/Guidelines). These +guidelines are a work in progress and are designed to help you identify +security best practices. For further information, feel free to reach out +to the OpenStack Security Group at openstack-security@lists.openstack.org. + +Notifications Impact +-------------------- + +Please specify any changes to notifications. Be that an extra notification, +changes to an existing notification, or removing a notification. + +Other End User Impact +--------------------- + +Aside from the API, are there other ways a user will interact with this feature? + +* Does this change have an impact on python-neutronclient? What does the user + interface there look like? + +Performance Impact +------------------ + +Describe any potential performance impact on the system, for example +how often will new code be called, and is there a major change to the calling +pattern of existing code. + +Examples of things to consider here include: + +* A periodic task might look like a small addition but if it calls conductor or + another service the load is multiplied by the number of nodes in the system. + +* A small change in a utility function or a commonly used decorator can have a + large impacts on performance. + +* Calls which result in a database queries (whether direct or via conductor) can + have a profound impact on performance when called in critical sections of the + code. + +* Will the change include any locking, and if so what considerations are there on + holding the lock? + +Other Deployer Impact +--------------------- + +Discuss things that will affect how you deploy and configure OpenStack +that have not already been mentioned, such as: + +* What config options are being added? Should they be more generic than + proposed (for example a flag that other hypervisor drivers might want to + implement as well)? Are the default values ones which will work well in + real deployments? + +* Is this a change that takes immediate effect after its merged, or is it + something that has to be explicitly enabled? + +* If this change is a new binary, how would it be deployed? + +* Please state anything that those doing continuous deployment, or those + upgrading from the previous release, need to be aware of. Also describe + any plans to deprecate configuration values or features. For example, if we + change the directory name that instances are stored in, how do we handle + instance directories created before the change landed? Do we move them? Do + we have a special case in the code? Do we assume that the operator will + recreate all the instances in their cloud? + +* Does this require downtime or manual intervention to apply when upgrading? + +Developer Impact +---------------- + +Discuss things that will affect other developers working on OpenStack, +such as: + +* If the blueprint proposes a change to the API, discussion of how other + plugins would implement the feature is required. + +Community Impact +---------------- + +Describe how this change fits in with the direction the Neutron community is +going. + +* Has the change been discussed on mailing lists, at the weekly Neutron + meeting, or at a Design Summit? + +* Does the change fit with the direction of the Neutron community? + +Alternatives +------------ + +What other ways could we do this thing? Why aren't we using those? This doesn't +have to be a full literature review, but it should demonstrate that thought has +been put into why the proposed solution is an appropriate one. + + +Implementation +============== + +Assignee(s) +----------- + +Who is leading the writing of the code? Or is this a blueprint where you're +throwing it out there to see who picks it up? + +If more than one person is working on the implementation, please designate the +primary author and contact. + +Primary assignee: + + +Other contributors: + + +Work Items +---------- + +Work items or tasks -- break the feature up into the things that need to be +done to implement it. Those parts might end up being done by different people, +but we're mostly trying to understand the timeline for implementation. + + +Dependencies +============ + +* Include specific references to specs and/or blueprints in neutron, or in other + projects, that this one either depends on or is related to. + +* If this requires functionality of another project that is not currently used + by Neutron (such as the glance v2 API when we previously only required v1), + document that fact. + +* Does this feature require any new library dependencies or code otherwise not + included in OpenStack? Or does it depend on a specific version of library? + + +Testing +======= + +Please discuss how the change will be tested. We especially want to know what +tempest tests will be added. It is assumed that unit test coverage will be +added so that doesn't need to be mentioned explicitly, but discussion of why +you think unit tests are sufficient and we don't need to add more tempest +tests would need to be included. + +Is this untestable in gate given current limitations (specific hardware / +software configurations available)? If so, are there mitigation plans (3rd +party testing, gate enhancements, etc). + +Tempest Tests +------------- + +List new, changed, or deleted Tempest tests in this section. If a blueprint +has been filed in the Tempest specs repository, please cross reference that +blueprint here. + +Functional Tests +---------------- + +Please document any functional tests which this change will require. New +features will require functional tests before being allowed to be merged. +Code refactors may require functional tests. + +API Tests +--------- + +Add changes to API tests in this section. This is required if the change is +adding, removing, or changing any API related code in Neutron. + + +Documentation Impact +==================== + +What is the impact on the docs team of this change? Some changes might require +donating resources to the docs team to have the documentation updated. Don't +repeat details discussed above, but please reference them here. + +User Documentation +------------------ + +Specify any User Documentation which needs to be changed. Reference the guides +which need updating due to this change. + +Developer Documentation +----------------------- + +If API changes are being made, specify the developer API documentation which +will be updated to reflect the new changes here. + +References +========== + +Please add any useful references here. You are not required to have any +reference. Moreover, this specification should still make sense when your +references are unavailable. Examples of what you could include are: + +* Links to mailing list or IRC discussions + +* Links to notes from a summit session + +* Links to relevant research, if appropriate + +* Related specifications as appropriate (e.g. link any vendor documentation) + +* Anything else you feel it is worthwhile to refer to + + +NOTE: Please remove everything from here and down. This section is meant to +show examples of how to format the spec. Some notes about using this template: @@ -106,311 +460,3 @@ seqdiag webserver <-- database; browser <-- webserver; } - - - -Problem description -=================== - -A detailed description of the problem: - -* For a new feature this might be use cases. Ensure you are clear about the - actors in each use case: End User vs Deployer - -* For a major reworking of something existing it would describe the - problems in that feature that are being addressed. - - -Proposed change -=============== - -Here is where you cover the change you propose to make in detail. How do you -propose to solve this problem? - -If this is one part of a larger effort make it clear where this piece ends. In -other words, what's the scope of this effort? - -Alternatives ------------- - -What other ways could we do this thing? Why aren't we using those? This doesn't -have to be a full literature review, but it should demonstrate that thought has -been put into why the proposed solution is an appropriate one. - -Data model impact ------------------ - -Changes which require modifications to the data model often have a wider impact -on the system. The community often has strong opinions on how the data model -should be evolved, from both a functional and performance perspective. It is -therefore important to capture and gain agreement as early as possible on any -proposed changes to the data model. - -Questions which need to be addressed by this section include: - -* What new data objects and/or database schema changes is this going to require? - -* What database migrations will accompany this change. - -* How will the initial set of new data objects be generated, for example if you - need to take into account existing instances, or modify other existing data - describe how that will work. - -REST API impact ---------------- - -For each API resource to be implemented using Neutron's attribute map -facility (see the neutron.api.v2.attributes), describe the resource -collection and specify the name, type, and other essential details of -each new or modified attribute. A table similar to the following may -be used: - -+----------+-------+---------+---------+------------+--------------+ -|Attribute |Type |Access |Default |Validation/ |Description | -|Name | | |Value |Conversion | | -+==========+=======+=========+=========+============+==============+ -|id |string |RO, all |generated|N/A |identity | -| |(UUID) | | | | | -+----------+-------+---------+---------+------------+--------------+ -|name |string |RW, all |'' |string |human-readable| -| | | | | |name | -+----------+-------+---------+---------+------------+--------------+ -|color |string |RW, admin|'red' |'red', |color | -| | | | |'yellow', or|indicating | -| | | | |'green' |state | -+----------+-------+---------+---------+------------+--------------+ - - -Here is the other example of the table using csv-table - - -.. csv-table:: CSVTable - :header: Attribute Name,Type,Access,Default Value,Validation Conversion,Description - - id,string (UUID),"RO, all",generated,N/A,identity - name,string,"RW, all","''",string,human-readable name - color,string,"RW, admin",red,"'red', 'yellow' or 'green'",color indicating state - - -Each API method which is either added or changed that does not use -Neutron's attribute map facility should have the following: - -* Specification for the method - - * A description of what the method does suitable for use in - user documentation - - * Method type (POST/PUT/GET/DELETE) - - * Normal http response code(s) - - * Expected error http response code(s) - - * A description for each possible error code should be included - describing semantic errors which can cause it such as - inconsistent parameters supplied to the method, or when an - instance is not in an appropriate state for the request to - succeed. Errors caused by syntactic problems covered by the JSON - schema defintion do not need to be included. - - * URL for the resource - - * Parameters which can be passed via the url - - * JSON schema definition for the body data if allowed - - * JSON schema definition for the response data if any - -* Example use case including typical API samples for both data supplied - by the caller and the response - -* Discuss any API policy changes, and discuss what things a deployer needs to - think about when defining their API policy. This is in reference to the - policy.json file. - -Note that the schema should be defined as restrictively as -possible. Parameters which are required should be marked as such and -only under exceptional circumstances should additional parameters -which are not defined in the schema be permitted (eg -additionaProperties should be False). - -Reuse of existing predefined parameter types such as regexps for -passwords and user defined names is highly encouraged. - -Security impact ---------------- - -Describe any potential security impact on the system. Some of the items to -consider include: - -* Does this change touch sensitive data such as tokens, keys, or user data? - -* Does this change alter the API in a way that may impact security, such as - a new way to access sensitive information or a new way to login? - -* Does this change involve cryptography or hashing? - -* Does this change require the use of sudo or any elevated privileges? - -* Does this change involve using or parsing user-provided data? This could - be directly at the API level or indirectly such as changes to a cache layer. - -* Can this change enable a resource exhaustion attack, such as allowing a - single API interaction to consume significant server resources? Some examples - of this include launching subprocesses for each connection, or entity - expansion attacks in XML. - -For more detailed guidance, please see the OpenStack Security Guidelines as -a reference (https://wiki.openstack.org/wiki/Security/Guidelines). These -guidelines are a work in progress and are designed to help you identify -security best practices. For further information, feel free to reach out -to the OpenStack Security Group at openstack-security@lists.openstack.org. - -Notifications impact --------------------- - -Please specify any changes to notifications. Be that an extra notification, -changes to an existing notification, or removing a notification. - -Other end user impact ---------------------- - -Aside from the API, are there other ways a user will interact with this feature? - -* Does this change have an impact on python-neutronclient? What does the user - interface there look like? - -Performance Impact ------------------- - -Describe any potential performance impact on the system, for example -how often will new code be called, and is there a major change to the calling -pattern of existing code. - -Examples of things to consider here include: - -* A periodic task might look like a small addition but if it calls conductor or - another service the load is multiplied by the number of nodes in the system. - -* A small change in a utility function or a commonly used decorator can have a - large impacts on performance. - -* Calls which result in a database queries (whether direct or via conductor) can - have a profound impact on performance when called in critical sections of the - code. - -* Will the change include any locking, and if so what considerations are there on - holding the lock? - -Other deployer impact ---------------------- - -Discuss things that will affect how you deploy and configure OpenStack -that have not already been mentioned, such as: - -* What config options are being added? Should they be more generic than - proposed (for example a flag that other hypervisor drivers might want to - implement as well)? Are the default values ones which will work well in - real deployments? - -* Is this a change that takes immediate effect after its merged, or is it - something that has to be explicitly enabled? - -* If this change is a new binary, how would it be deployed? - -* Please state anything that those doing continuous deployment, or those - upgrading from the previous release, need to be aware of. Also describe - any plans to deprecate configuration values or features. For example, if we - change the directory name that instances are stored in, how do we handle - instance directories created before the change landed? Do we move them? Do - we have a special case in the code? Do we assume that the operator will - recreate all the instances in their cloud? - -Developer impact ----------------- - -Discuss things that will affect other developers working on OpenStack, -such as: - -* If the blueprint proposes a change to the API, discussion of how other - plugins would implement the feature is required. - - -Implementation -============== - -Assignee(s) ------------ - -Who is leading the writing of the code? Or is this a blueprint where you're -throwing it out there to see who picks it up? - -If more than one person is working on the implementation, please designate the -primary author and contact. - -Primary assignee: - - -Other contributors: - - -Work Items ----------- - -Work items or tasks -- break the feature up into the things that need to be -done to implement it. Those parts might end up being done by different people, -but we're mostly trying to understand the timeline for implementation. - - -Dependencies -============ - -* Include specific references to specs and/or blueprints in neutron, or in other - projects, that this one either depends on or is related to. - -* If this requires functionality of another project that is not currently used - by Neutron (such as the glance v2 API when we previously only required v1), - document that fact. - -* Does this feature require any new library dependencies or code otherwise not - included in OpenStack? Or does it depend on a specific version of library? - - -Testing -======= - -Please discuss how the change will be tested. We especially want to know what -tempest tests will be added. It is assumed that unit test coverage will be -added so that doesn't need to be mentioned explicitly, but discussion of why -you think unit tests are sufficient and we don't need to add more tempest -tests would need to be included. - -Is this untestable in gate given current limitations (specific hardware / -software configurations available)? If so, are there mitigation plans (3rd -party testing, gate enhancements, etc). - - -Documentation Impact -==================== - -What is the impact on the docs team of this change? Some changes might require -donating resources to the docs team to have the documentation updated. Don't -repeat details discussed above, but please reference them here. - - -References -========== - -Please add any useful references here. You are not required to have any -reference. Moreover, this specification should still make sense when your -references are unavailable. Examples of what you could include are: - -* Links to mailing list or IRC discussions - -* Links to notes from a summit session - -* Links to relevant research, if appropriate - -* Related specifications as appropriate (e.g. link any vendor documentation) - -* Anything else you feel it is worthwhile to refer to diff --git a/tests/test_titles.py b/tests/test_titles.py index 3cdcf4506..4cad32dae 100644 --- a/tests/test_titles.py +++ b/tests/test_titles.py @@ -52,21 +52,22 @@ class TestTitles(testtools.TestCase): return titles def _check_titles(self, titles): - problem = 'Problem description' + problem = 'Problem Description' self.assertIn(problem, titles) self.assertEqual(0, len(titles[problem])) - proposed = 'Proposed change' + proposed = 'Proposed Change' self.assertIn(proposed, titles) - self.assertIn('Alternatives', titles[proposed]) - self.assertIn('Data model impact', titles[proposed]) - self.assertIn('REST API impact', titles[proposed]) - self.assertIn('Security impact', titles[proposed]) - self.assertIn('Notifications impact', titles[proposed]) - self.assertIn('Other end user impact', titles[proposed]) + self.assertIn('Data Model Impact', titles[proposed]) + self.assertIn('REST API Impact', titles[proposed]) + self.assertIn('Security Impact', titles[proposed]) + self.assertIn('Notifications Impact', titles[proposed]) + self.assertIn('Other End User Impact', titles[proposed]) self.assertIn('Performance Impact', titles[proposed]) - self.assertIn('Other deployer impact', titles[proposed]) - self.assertIn('Developer impact', titles[proposed]) + self.assertIn('Other Deployer Impact', titles[proposed]) + self.assertIn('Developer Impact', titles[proposed]) + self.assertIn('Community Impact', titles[proposed]) + self.assertIn('Alternatives', titles[proposed]) impl = 'Implementation' self.assertIn(impl, titles) @@ -80,11 +81,16 @@ class TestTitles(testtools.TestCase): testing = 'Testing' self.assertIn(testing, titles) - self.assertEqual(0, len(titles[testing])) + self.assertIn('Tempest Tests', titles[testing]) + self.assertIn('Functional Tests', titles[testing]) + self.assertIn('API Tests', titles[testing]) + self.assertEqual(3, len(titles[testing])) docs = 'Documentation Impact' self.assertIn(docs, titles) - self.assertEqual(0, len(titles[docs])) + self.assertIn('User Documentation', titles[docs]) + self.assertIn('Developer Documentation', titles[docs]) + self.assertEqual(2, len(titles[docs])) refs = 'References' self.assertIn(refs, titles) @@ -93,7 +99,7 @@ class TestTitles(testtools.TestCase): self.assertEqual(7, len(titles)) def test_template(self): - files = glob.glob('specs/*.rst') + glob.glob('specs/*/*') + files = glob.glob('specs/*.rst') + glob.glob('specs/kilo/*') for filename in files: self.assertTrue(filename.endswith(".rst"), "spec's file must uses 'rst' extension.")