openstack
/
neutron-specs
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-1

(4 comments)

Patch-set: 2
This commit is contained in:
Gerrit User 6951 2014-04-28 20:21:22 +00:00 committed by Gerrit Code Review
parent 59d342df49
commit 8a86f3a059
1 changed files with 68 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
adcbbf9477c27990c1d9b62bdd7dc45b30a30a39
View File

@ -244,6 +244,40 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXX//sn4\u003d",
"filename": "specs/juno/lbaas-api-and-objmodel-improvement.rst",
"patchSetId": 2
},
"lineNbr": 103,
"author": {
"id": 6951
},
"writtenOn": "2014-04-28T20:21:22Z",
"side": 1,
"message": "Need more details on this, no matter how obvious it may seem. Is it unchanged?",
"revId": "adcbbf9477c27990c1d9b62bdd7dc45b30a30a39",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXX//snw\u003d",
"filename": "specs/juno/lbaas-api-and-objmodel-improvement.rst",
"patchSetId": 2
},
"lineNbr": 104,
"author": {
"id": 6951
},
"writtenOn": "2014-04-28T20:21:22Z",
"side": 1,
"message": "Need more details on this as well. Unchanged?",
"revId": "adcbbf9477c27990c1d9b62bdd7dc45b30a30a39",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXX//x6U\u003d",
@ -279,6 +313,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXX//xwQ\u003d",
"filename": "specs/juno/lbaas-api-and-objmodel-improvement.rst",
"patchSetId": 2
},
"lineNbr": 143,
"author": {
"id": 6951
},
"writtenOn": "2014-04-28T20:21:22Z",
"side": 1,
"message": "If VIP is to become the root object, I think it would make more sense for the VIP to have a reference to listeners. It looks like the VIP and Pool will have to be created first and then the Listener is created last and that what ties everything together. Just because the code may take care of creating the listener for a user doesn\u0027t mean that makes the VIP the root object. This makes it seem like the Listener is the root object, just like the Pool is currently.",
"revId": "adcbbf9477c27990c1d9b62bdd7dc45b30a30a39",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXX//x6I\u003d",
@ -313,6 +364,23 @@
"revId": "adcbbf9477c27990c1d9b62bdd7dc45b30a30a39",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXX//xwM\u003d",
"filename": "specs/juno/lbaas-api-and-objmodel-improvement.rst",
"patchSetId": 2
},
"lineNbr": 145,
"author": {
"id": 6951
},
"writtenOn": "2014-04-28T20:21:22Z",
"side": 1,
"message": "Read-Only back-references to listeners that are pointing to the pool would be nice.",
"revId": "adcbbf9477c27990c1d9b62bdd7dc45b30a30a39",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}