Update patch set 5
Patch Set 5: (10 comments) Patch-set: 5 CC: Gerrit User 1131 <1131@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 1131
Gerrit Code Review
parent
7c15d540e6
commit
8b59c8f6fe
|
|
@ -0,0 +1,222 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "ba6e66cf_8724a766",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1131
|
||||
},
|
||||
"writtenOn": "2023-01-10T15:22:45Z",
|
||||
"side": 1,
|
||||
"message": "I think functionally the spec looks good, most of my comments are just text nits.",
|
||||
"revId": "22c5fd829373bea0e51c367826dcc63c05f41901",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "f71c2567_4e90bb35",
|
||||
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 46,
|
||||
"author": {
|
||||
"id": 1131
|
||||
},
|
||||
"writtenOn": "2023-01-10T15:22:45Z",
|
||||
"side": 1,
|
||||
"message": "nit: s/it is the only one that\n\nsince a router isn\u0027t male/female :)",
|
||||
"range": {
|
||||
"startLine": 46,
|
||||
"startChar": 21,
|
||||
"endLine": 46,
|
||||
"endChar": 43
|
||||
},
|
||||
"revId": "22c5fd829373bea0e51c367826dcc63c05f41901",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e45c1a6a_10404b0b",
|
||||
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 56,
|
||||
"author": {
|
||||
"id": 1131
|
||||
},
|
||||
"writtenOn": "2023-01-10T15:22:45Z",
|
||||
"side": 1,
|
||||
"message": "nit: s/Gateways",
|
||||
"range": {
|
||||
"startLine": 56,
|
||||
"startChar": 7,
|
||||
"endLine": 56,
|
||||
"endChar": 14
|
||||
},
|
||||
"revId": "22c5fd829373bea0e51c367826dcc63c05f41901",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "d8575e1a_db77dfcb",
|
||||
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 76,
|
||||
"author": {
|
||||
"id": 1131
|
||||
},
|
||||
"writtenOn": "2023-01-10T15:22:45Z",
|
||||
"side": 1,
|
||||
"message": "nit: s/responding to",
|
||||
"range": {
|
||||
"startLine": 76,
|
||||
"startChar": 48,
|
||||
"endLine": 76,
|
||||
"endChar": 58
|
||||
},
|
||||
"revId": "22c5fd829373bea0e51c367826dcc63c05f41901",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "03903ea2_1439dca3",
|
||||
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 92,
|
||||
"author": {
|
||||
"id": 1131
|
||||
},
|
||||
"writtenOn": "2023-01-10T15:22:45Z",
|
||||
"side": 1,
|
||||
"message": "nit: the beginning of this sentence is a little hard to understand, maybe:\n\n\"OVN support of distributed routing for an IPv6 GUA follows the same idea of the IPv4 case...\"",
|
||||
"revId": "22c5fd829373bea0e51c367826dcc63c05f41901",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "42e54434_96236c87",
|
||||
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 97,
|
||||
"author": {
|
||||
"id": 1131
|
||||
},
|
||||
"writtenOn": "2023-01-10T15:22:45Z",
|
||||
"side": 1,
|
||||
"message": "nit: s/IPv4\n\nAnd two lines in a row ending in \u0027:\u0027 is hard for me to parse, so maybe a slight re-wording would help.",
|
||||
"range": {
|
||||
"startLine": 97,
|
||||
"startChar": 13,
|
||||
"endLine": 97,
|
||||
"endChar": 17
|
||||
},
|
||||
"revId": "22c5fd829373bea0e51c367826dcc63c05f41901",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "1c7e0804_cb19e1bd",
|
||||
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 164,
|
||||
"author": {
|
||||
"id": 1131
|
||||
},
|
||||
"writtenOn": "2023-01-10T15:22:45Z",
|
||||
"side": 1,
|
||||
"message": "nit: s/IPv4",
|
||||
"range": {
|
||||
"startLine": 164,
|
||||
"startChar": 4,
|
||||
"endLine": 164,
|
||||
"endChar": 8
|
||||
},
|
||||
"revId": "22c5fd829373bea0e51c367826dcc63c05f41901",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "41ace151_5e410833",
|
||||
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 205,
|
||||
"author": {
|
||||
"id": 1131
|
||||
},
|
||||
"writtenOn": "2023-01-10T15:22:45Z",
|
||||
"side": 1,
|
||||
"message": "s/Neutron (remove The)",
|
||||
"range": {
|
||||
"startLine": 205,
|
||||
"startChar": 0,
|
||||
"endLine": 205,
|
||||
"endChar": 11
|
||||
},
|
||||
"revId": "22c5fd829373bea0e51c367826dcc63c05f41901",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e320604f_73ab31cb",
|
||||
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 208,
|
||||
"author": {
|
||||
"id": 1131
|
||||
},
|
||||
"writtenOn": "2023-01-10T15:22:45Z",
|
||||
"side": 1,
|
||||
"message": "s/neutron",
|
||||
"range": {
|
||||
"startLine": 208,
|
||||
"startChar": 37,
|
||||
"endLine": 208,
|
||||
"endChar": 48
|
||||
},
|
||||
"revId": "22c5fd829373bea0e51c367826dcc63c05f41901",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "2929e3f3_11349427",
|
||||
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 212,
|
||||
"author": {
|
||||
"id": 1131
|
||||
},
|
||||
"writtenOn": "2023-01-10T15:22:45Z",
|
||||
"side": 1,
|
||||
"message": "s/deletes or \u0027must delete\u0027 ?",
|
||||
"range": {
|
||||
"startLine": 212,
|
||||
"startChar": 23,
|
||||
"endLine": 212,
|
||||
"endChar": 29
|
||||
},
|
||||
"revId": "22c5fd829373bea0e51c367826dcc63c05f41901",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue