openstack
/
neutron-specs
Code Issues Proposed changes

Update patch set 8 

Patch Set 8: Code-Review+2

(3 comments)

Patch-set: 8
Reviewer: Gerrit User 4694 <4694@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 01cdd809a7a493095907f92d6a5fc9f9573952bb
This commit is contained in:
Gerrit User 4694 2023-01-12 17:15:02 +00:00 committed by Gerrit Code Review
parent a6a6d6d03c
commit 948f0f7434
1 changed files with 63 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
12f45301a693e526a8a7bd8128161e41f89a8aac
View File

@ -16,6 +16,69 @@
"message": "Thanks Rodolfo for the spec. It does looks good to me",
"revId": "12f45301a693e526a8a7bd8128161e41f89a8aac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "fcfe7b3b_fda618bb",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 8
},
"lineNbr": 0,
"author": {
"id": 4694
},
"writtenOn": "2023-01-12T17:15:02Z",
"side": 1,
"message": "Just a couple of nits if you have to re-spin a patch",
"revId": "12f45301a693e526a8a7bd8128161e41f89a8aac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "84754165_cd884bcc",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 8
},
"lineNbr": 66,
"author": {
"id": 4694
},
"writtenOn": "2023-01-12T17:15:02Z",
"side": 1,
"message": "Nit: extension (https://github.com/openstack/neutron-lib/blob/master/neutron_lib/agent/extension.py)",
"range": {
"startLine": 66,
"startChar": 20,
"endLine": 66,
"endChar": 30
},
"revId": "12f45301a693e526a8a7bd8128161e41f89a8aac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f0771542_236e583a",
"filename": "specs/2023.1/ovn-monitor.rst",
"patchSetId": 8
},
"lineNbr": 259,
"author": {
"id": 4694
},
"writtenOn": "2023-01-12T17:15:02Z",
"side": 1,
"message": "redundant IMO",
"range": {
"startLine": 259,
"startChar": 21,
"endLine": 259,
"endChar": 27
},
"revId": "12f45301a693e526a8a7bd8128161e41f89a8aac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}