Update patch set 3

Patch Set 3: Code-Review-1 (25 comments) Patch-set: 3 Reviewer: Gerrit User 4694 <4694@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 8bd75eaf6c190e7374da2706a797e1a485640772
2023-10-18 23:22:41 +00:00 · 2023-10-18 23:22:41 +00:00 · a5b5a4680a
parent 91399a2f6f
commit a5b5a4680a
1 changed files with 567 additions and 0 deletions
--- a/567
+++ b/567
@ -0,0 +1,567 @@
+{
+  "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "d3c9aa22_a8d3cd1e",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 3
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "Looks pretty good to me. Some questions and suggestions",
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "c5e75da3_a87c7283",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 109,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "I was intrigued by this spelling. I think the word you want to use is \"therefore\": https://languagetool.org/insights/post/word-choice-therefore-or-therefor/",
+      "range": {
+        "startLine": 109,
+        "startChar": 11,
+        "endLine": 109,
+        "endChar": 19
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "85db8f59_4c088674",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 175,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "Ditto",
+      "range": {
+        "startLine": 175,
+        "startChar": 3,
+        "endLine": 175,
+        "endChar": 11
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "23d23500_c5a9ccfc",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 195,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "should this be lsp_ts1_lr1?",
+      "range": {
+        "startLine": 195,
+        "startChar": 2,
+        "endLine": 195,
+        "endChar": 13
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "91e3347d_018dfbce",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 233,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "And this has to be set by the operator, either manually or with automation, right?",
+      "range": {
+        "startLine": 233,
+        "startChar": 30,
+        "endLine": 233,
+        "endChar": 69
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "e10a1511_5b9afc7b",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 259,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "completely",
+      "range": {
+        "startLine": 259,
+        "startChar": 27,
+        "endLine": 259,
+        "endChar": 38
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "135a3c9d_fc968073",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 266,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "You want \"below\": https://www.merriam-webster.com/dictionary/bellow",
+      "range": {
+        "startLine": 266,
+        "startChar": 30,
+        "endLine": 266,
+        "endChar": 36
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "abde2cca_f0f28e29",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 268,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "\"is to implement\" or \"implements\"",
+      "range": {
+        "startLine": 268,
+        "startChar": 54,
+        "endLine": 268,
+        "endChar": 63
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "829d7fe6_69e34511",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 274,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "wouldn\u0027t \"automatically creates\" better?",
+      "range": {
+        "startLine": 274,
+        "startChar": 20,
+        "endLine": 274,
+        "endChar": 38
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "21b3ec17_7d9b110d",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 300,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "Ditto",
+      "range": {
+        "startLine": 300,
+        "startChar": 20,
+        "endLine": 300,
+        "endChar": 38
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "1e91e679_a39743ae",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 320,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "performs",
+      "range": {
+        "startLine": 320,
+        "startChar": 18,
+        "endLine": 320,
+        "endChar": 25
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "7d261a3f_cdaf3f92",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 324,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "For clarity, consider:\n\n\"... in this case for LogicalSwitchs with the \u0027intercon-ts\u0027 key in the other_config register and Logical_Switch_Ports with the field \u0027type\u0027 set to \u0027remote\u0027 and don\u0027t remove them\"",
+      "range": {
+        "startLine": 321,
+        "startChar": 42,
+        "endLine": 324,
+        "endChar": 5
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "1d4c0362_d1958de7",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 329,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "automatically creates",
+      "range": {
+        "startLine": 329,
+        "startChar": 20,
+        "endLine": 329,
+        "endChar": 38
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "6abb351b_04930f43",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 331,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "the external_ids",
+      "range": {
+        "startLine": 331,
+        "startChar": 35,
+        "endLine": 331,
+        "endChar": 47
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "32e0ddab_e3f588ee",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 395,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "performs",
+      "range": {
+        "startLine": 395,
+        "startChar": 5,
+        "endLine": 395,
+        "endChar": 12
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "b2ddac39_b10b3cc3",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 398,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "Consider a suggestion similar to the one offered for line 321",
+      "range": {
+        "startLine": 397,
+        "startChar": 22,
+        "endLine": 398,
+        "endChar": 69
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "5bd6d5fa_11063991",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 406,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "automatically creates",
+      "range": {
+        "startLine": 406,
+        "startChar": 20,
+        "endLine": 406,
+        "endChar": 39
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "d8d8a765_9c2f8adf",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 410,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "s/set/have",
+      "range": {
+        "startLine": 410,
+        "startChar": 53,
+        "endLine": 410,
+        "endChar": 56
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "81b84a1b_b74ca0d6",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 410,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "the operator",
+      "range": {
+        "startLine": 410,
+        "startChar": 35,
+        "endLine": 410,
+        "endChar": 43
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "417ebd8e_3f9759e8",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 446,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "s/set/have",
+      "range": {
+        "startLine": 446,
+        "startChar": 53,
+        "endLine": 446,
+        "endChar": 56
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "371a7e8e_cf9589c3",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 446,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "the operator",
+      "range": {
+        "startLine": 446,
+        "startChar": 35,
+        "endLine": 446,
+        "endChar": 43
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "3dd4d24f_f2f33e76",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 474,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "the operator",
+      "range": {
+        "startLine": 474,
+        "startChar": 63,
+        "endLine": 474,
+        "endChar": 71
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "c3936668_b3e36b0e",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 476,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "the OVN",
+      "range": {
+        "startLine": 476,
+        "startChar": 4,
+        "endLine": 476,
+        "endChar": 7
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "cdf5c0b4_5fb173c9",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 478,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "Consider a suggestion similar to the one offered for line 321",
+      "range": {
+        "startLine": 477,
+        "startChar": 0,
+        "endLine": 478,
+        "endChar": 29
+      },
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "cec3048b_45b33629",
+        "filename": "specs/2024.1/ml2ovn-coexistence-support-ovn-interconnect.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 520,
+      "author": {
+        "id": 4694
+      },
+      "writtenOn": "2023-10-18T23:22:41Z",
+      "side": 1,
+      "message": "How about some documentation. I think a chapter explaining how this works would be very helpful here: https://github.com/openstack/neutron/tree/master/doc/source/admin",
+      "revId": "0e8d530ba16d94428a6a9581107003516ae76648",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}