openstack
/
neutron-specs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: I would prefer that you didn't merge this

(7 inline comments)



Patch-set: 1
Label: Code-Review=-1
Label: Workflow=0
This commit is contained in:
Gerrit User 261 2014-04-17 18:45:00 +00:00 committed by Gerrit Code Review
parent 41ced5d3e2
commit a7e98a996c
1 changed files with 119 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

119
31ffc682f64125f8639ae6d59632b4693779b590
View File

@ -51,6 +51,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//vyc\u003d",
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
"patchSetId": 1
},
"lineNbr": 32,
"author": {
"id": 261
},
"writtenOn": "2014-04-17T18:45:00Z",
"side": 1,
"message": "You can fix the diagram if you wish, but it seems it\u0027s simple enough that you can describe the situation with a text paragraph",
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//wRk\u003d",
@ -85,6 +102,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//vxE\u003d",
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
"patchSetId": 1
},
"lineNbr": 61,
"author": {
"id": 261
},
"writtenOn": "2014-04-17T18:45:00Z",
"side": 1,
"message": "How will the CRD server store this information?\nThis is not important for Neutron, but I imagine it will create objects, and these objects might have identifiers.\nIf you are planning to store mappings between neutron and crd identifiers in neutron\u0027s data model you should state it here.",
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//wQg\u003d",
@ -101,6 +135,91 @@
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//v1M\u003d",
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
"patchSetId": 1
},
"lineNbr": 81,
"author": {
"id": 261
},
"writtenOn": "2014-04-17T18:45:00Z",
"side": 1,
"message": "I can\u0027t help but I feel terribly confused by this statement:\n\"the crd server i a copy of the neutronclient httpclient class\".\n\nIs that a server or a client then?",
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//v0Q\u003d",
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
"patchSetId": 1
},
"lineNbr": 87,
"author": {
"id": 261
},
"writtenOn": "2014-04-17T18:45:00Z",
"side": 1,
"message": "not really. You\u0027re adding a call to a 3rd party system for neutron API call. For instance, do you expect a create_port with the crd mech driver to be slower, or will the performance impact be negligible?",
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//vwU\u003d",
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
"patchSetId": 1
},
"lineNbr": 92,
"author": {
"id": 261
},
"writtenOn": "2014-04-17T18:45:00Z",
"side": 1,
"message": "Do you mean that this change won\u0027t have any effect with the default neutron configuration?",
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//vwA\u003d",
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
"patchSetId": 1
},
"lineNbr": 122,
"author": {
"id": 261
},
"writtenOn": "2014-04-17T18:45:00Z",
"side": 1,
"message": "I don\u0027t think there are dependencies for your blueprint!",
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//vvg\u003d",
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
"patchSetId": 1
},
"lineNbr": 127,
"author": {
"id": 261
},
"writtenOn": "2014-04-17T18:45:00Z",
"side": 1,
"message": "Do you mean existing testing or are you going to provide more tests (which, I think, you\u0027ll need to run on your own CI)",
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}