openstack
/
neutron-specs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(2 comments)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 35432 \u003c35432@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35432\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 15554 \u003c15554@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35432\u003e replied on the change"}
This commit is contained in:
Gerrit User 35432 2023-11-16 11:44:36 +00:00 committed by Gerrit Code Review
parent 6457be961b
commit b10c3c6fa9
1 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
33f1231954f739b6105ce35bca96cde10111af0c
View File

@ -109,6 +109,30 @@
"revId": "33f1231954f739b6105ce35bca96cde10111af0c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "779ad168_61306e7b",
"filename": "specs/2024.1/l3bgp-peer-connect-mode.rst",
"patchSetId": 1
},
"lineNbr": 46,
"author": {
"id": 35432
},
"writtenOn": "2023-11-16T11:44:36Z",
"side": 1,
"message": "Thanks for your review Bence.\n\nThe BGP speaker driver supports a list of IP addresses `bgp_server_host` to listen on a specific TCP port `bgp_server_port` [1]. The neutron dynamic routing agent uses the default values for these two driver config options, e.g: \u00270.0.0.0\u0027 to listen all IPv4 local addresses, and \u0027::\u0027 to listen all IPv6 local addresses.\n\nIt\u0027s not required to configure a specific IP address used in DRAgent because this information is already configured on the switch side. I mean, the operator needs to configure the neighbor\u0027s IP address in the switch router\u0027s BGP session, like Quagga configuration sample [2]: neighbor \u003cdr_agent IP address\u003e remote-as \u003cBgpSpeaker local_as\u003e\n\nIn this context, the BGP peer address will always be known by the switch because the BGP communication protocol supported by DRAgent is IPv4 unicast and IPv6 unicast (any BGP multicast protocol isn\u0027t implemented in DRAgent).\n\n\n[1] https://docs.openstack.org/os-ken/latest/library_bgp_speaker_ref.html\n[2] https://docs.openstack.org/neutron-dynamic-routing/latest/admin/bgp-speaker.html",
"parentUuid": "d33104e2_d3ceb1cf",
"range": {
"startLine": 45,
"startChar": 5,
"endLine": 46,
"endChar": 15
},
"revId": "33f1231954f739b6105ce35bca96cde10111af0c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -172,6 +196,24 @@
"revId": "33f1231954f739b6105ce35bca96cde10111af0c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8f9ef795_4cb1aa67",
"filename": "specs/2024.1/l3bgp-peer-connect-mode.rst",
"patchSetId": 1
},
"lineNbr": 63,
"author": {
"id": 35432
},
"writtenOn": "2023-11-16T11:44:36Z",
"side": 1,
"message": "I\u0027m not sure, this setting is specific to the BGP driver used by DRAgent (currently os-ken) and not to DRAgent itself. I mean, if os-ken removes support for this option or is replaced by another implementation, this could cause a cascading effect to adjust API\u0027s, neutron-lib, etc.\nIf it is a requirement to extend the BGP speaker API, that\u0027s fine, I just can\u0027t see the real benefit of making this option available via API for Neutron.",
"parentUuid": "018d5b40_6fce74a0",
"revId": "33f1231954f739b6105ce35bca96cde10111af0c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {