Update patch set 6

Patch Set 6:

(3 comments)

Patch-set: 6
Attention: {"person_ident":"Gerrit User 11604 \u003c11604@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 16688 \u003c16688@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change"}
This commit is contained in:
Gerrit User 11604 2022-11-04 12:38:33 +00:00 committed by Gerrit Code Review
parent 52e34d7698
commit b2daed3070
1 changed files with 57 additions and 0 deletions

View File

@ -182,6 +182,63 @@
},
"revId": "09ee72205f522b16261a4ae919e03511386c0e9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5762cd5a_f91d3267",
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
"patchSetId": 6
},
"lineNbr": 99,
"author": {
"id": 11604
},
"writtenOn": "2022-11-04T12:38:33Z",
"side": 1,
"message": "this does not line up with the tabel by the way.\n\ni also prefer this name to what you have in the table and in the example below.\n\nif we stick withthe CUSTOM_ prefix can we just use this trait instead of \nCUSTOM_TUNNELLED_RP_TUNNELLED",
"range": {
"startLine": 99,
"startChar": 1,
"endLine": 99,
"endChar": 26
},
"revId": "09ee72205f522b16261a4ae919e03511386c0e9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "676e4dd7_b58a9a08",
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
"patchSetId": 6
},
"lineNbr": 165,
"author": {
"id": 11604
},
"writtenOn": "2022-11-04T12:38:33Z",
"side": 1,
"message": "your going to have to reshape the placment allocation or nova will for any existing port that have a minbandwith qos rule applied to a tunneled port.\n\nthat will be non trivial.",
"revId": "09ee72205f522b16261a4ae919e03511386c0e9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1c7908f5_a5c4455e",
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
"patchSetId": 6
},
"lineNbr": 180,
"author": {
"id": 11604
},
"writtenOn": "2022-11-04T12:38:33Z",
"side": 1,
"message": "i think your are mixing ups how placemnt is ment to work\n\ninventories track total avalaibel capastyity and have a reserved value.\nthe reserved value tracks capatiy that is reserved for non openstack usage.\n\nthe consumtion of the resouces i.e. the usage is compute form the allcoations against the inventoies.\n\nso how this need to work is the reshape api need to be used to reshape the allocation when this feature is enabled.\n\nthat reshape will likely need to be done by nova.\nit may be possibel to do it form neutron but we need to ensure that nova will generate the same allocations if we migrate or run the heall allcoations comand.",
"revId": "09ee72205f522b16261a4ae919e03511386c0e9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}