openstack
/
neutron-specs
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-1

(4 comments)

Patch-set: 2
Reviewer: Gerrit User 31450 <31450@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Reviewer: Gerrit User 19118 <19118@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Reviewer: Gerrit User 11975 <11975@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 19118 \u003c19118@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_11975\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 31450 \u003c31450@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_11975\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 16688 \u003c16688@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_11975\u003e replied on the change"}
This commit is contained in:
Gerrit User 11975 2022-10-26 07:58:00 +00:00 committed by Gerrit Code Review
parent ecbda239f7
commit be4cfc002d
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
0c8ccb5191a2ebb93ed7601a161461f283d85b46 Normal file
View File

@ -0,0 +1,72 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "720a8b6d_33b5728d",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 11975
},
"writtenOn": "2022-10-26T07:58:00Z",
"side": 1,
"message": "Generally looks very good for me. -1 just because of the testing part.",
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "03da1a37_bd9f52fe",
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.srt",
"patchSetId": 2
},
"lineNbr": 59,
"author": {
"id": 11975
},
"writtenOn": "2022-10-26T07:58:00Z",
"side": 1,
"message": "I don\u0027t think any operator will have clash here but maybe we should consider making this name to be configurable in Neutron to avoid potential problems during upgrade process?",
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "06f6d33e_2041d3ee",
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.srt",
"patchSetId": 2
},
"lineNbr": 129,
"author": {
"id": 11975
},
"writtenOn": "2022-10-26T07:58:00Z",
"side": 1,
"message": "+1 for new upgrade check",
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "db6e1ca8_a189d10d",
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.srt",
"patchSetId": 2
},
"lineNbr": 153,
"author": {
"id": 11975
},
"writtenOn": "2022-10-26T07:58:00Z",
"side": 1,
"message": "As we recently discussed internally, can You maybe elaborate more about what kind of tempest tests do You think should be added to test it? Some API tests or scenario test?",
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}