Update patch set 2

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 5948 \u003c5948@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_15554\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 15554 \u003c15554@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_15554\u003e replied on the change"}
This commit is contained in:
Gerrit User 15554 2022-11-08 14:47:11 +00:00 committed by Gerrit Code Review
parent 34cd317a3c
commit c22a024497
1 changed files with 24 additions and 0 deletions

View File

@ -118,6 +118,30 @@
},
"revId": "0d9d5f84a5efacea47b5c46fa3da3ea7882876d9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "34e37152_e02c5ff7",
"filename": "specs/2023.1/ovs-tx-steering.rst",
"patchSetId": 2
},
"lineNbr": 63,
"author": {
"id": 15554
},
"writtenOn": "2022-11-08T14:47:11Z",
"side": 1,
"message": "\u003e I see, the difficulty is that currently there is no mechanism in agent to inform server about separate attributes of the port. So either port was fully processed and applied (and hence ACTIVE) or there were some errors and port can\u0027t be treated as ACTIVE. Right?\n\nExactly. And just because a hint was not applied I don\u0027t want to set the port\u0027s status to ERROR, since the port is probably still fully functional. We just missed some performance tuning.\n\n\u003e I agree that introducing agent-\u003eserver structured feedback makes this change way more complicated.\n\nThat\u0027s exactly the tradeoff I also see between the above options (1) and (2).\n\n\u003e For better UX I still think it makes sense to return \"hints\" in GET response, even we don\u0027t know if hints were followed or not. Otherwise the one who creates ports may end up confused: which ports were created with hints and which not.\n\u003e wdyt?\n\nI definitely want to return the hints in a GET response. If anywhere in the spec I wrote something contradicting this, please let me know where, because it was not my intention.",
"parentUuid": "d795a813_d0f3602a",
"range": {
"startLine": 59,
"startChar": 27,
"endLine": 63,
"endChar": 73
},
"revId": "0d9d5f84a5efacea47b5c46fa3da3ea7882876d9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}