openstack
/
neutron-specs
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(9 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 24824 \u003c24824@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_24824\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 8313 \u003c8313@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_24824\u003e replied on the change"}
This commit is contained in:
Gerrit User 24824 2023-02-10 14:04:48 +00:00 committed by Gerrit Code Review
parent 8ed49a8189
commit e5b4159328
2 changed files with 210 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
24268d016484e0227f61221942d87193812d8e2f
View File

@ -412,6 +412,30 @@
"revId": "24268d016484e0227f61221942d87193812d8e2f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7b6c8dcf_290e465b",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 1
},
"lineNbr": 121,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "Agreed, I think having a separate option for it could be a reasonable approach.\n\nI didn\u0027t want to overload operators with various options but since it\u0027s support is limited to some use-cases I think it\u0027s necessary to have an option.",
"parentUuid": "3b2bd1ec_1300bc8a",
"range": {
"startLine": 121,
"startChar": 0,
"endLine": 121,
"endChar": 27
},
"revId": "24268d016484e0227f61221942d87193812d8e2f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {

186
8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca
View File

@ -23,6 +23,30 @@
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2924bb73_19409c94",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 50,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "Yes, you got it right - I think your version is better. I need to have less clericalism in the text :^)",
"parentUuid": "304a229b_11e5bc65",
"range": {
"startLine": 49,
"startChar": 0,
"endLine": 50,
"endChar": 26
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +70,30 @@
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9799e8f8_8a6688ad",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 53,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "Yes, having too many sessions is a concern.\n\nWe could approach it in various to reduce the number of sessions, e.g. use a \"shared\" router in an admin project and an intermediate virtual network through which other other routers would connect to it or something else.\n\nThis also raises an RBAC-related concern: letting random tenants configure BFD probably isn\u0027t a good idea so we may require changing BFD parameters to be a cloud admin only operation.",
"parentUuid": "63d8587c_ec4b4165",
"range": {
"startLine": 53,
"startChar": 0,
"endLine": 53,
"endChar": 78
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -69,6 +117,30 @@
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "558e2ae7_ee1a10d1",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 92,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "Ack",
"parentUuid": "d7b99645_e43d6c6c",
"range": {
"startLine": 86,
"startChar": 0,
"endLine": 92,
"endChar": 59
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -115,6 +187,30 @@
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ba6d8854_a172fc2f",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 131,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "Thanks for spotting, I\u0027ll fix it.",
"parentUuid": "e32e247c_87286462",
"range": {
"startLine": 131,
"startChar": 56,
"endLine": 131,
"endChar": 65
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -138,6 +234,30 @@
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "183f365e_7c807010",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 144,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "ty, definitely a typo.",
"parentUuid": "e4c826d7_281520bd",
"range": {
"startLine": 144,
"startChar": 4,
"endLine": 144,
"endChar": 10
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -184,6 +304,30 @@
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b7e6b7cd_d1d8d49f",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 192,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "Sorry, I took a subset of definitions from the BFD support spec for compatibility with it:\n\nhttps://specs.openstack.org/openstack/neutron-specs/specs/xena/bfd_support.html\n\nBut I missed editing this part of the description - thanks for spotting it.\n\nI\u0027ll change this part.",
"parentUuid": "d10aacbc_4a886ed6",
"range": {
"startLine": 192,
"startChar": 60,
"endLine": 192,
"endChar": 74
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -254,6 +398,30 @@
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "12ea247b_9cc56859",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 310,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "I think we\u0027ll need an API for this that goes with this spec to have that visibility:\n\nhttps://specs.openstack.org/openstack/neutron-specs/specs/xena/bfd_support.html",
"parentUuid": "23739657_cb257ff6",
"range": {
"startLine": 306,
"startChar": 0,
"endLine": 310,
"endChar": 70
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -270,6 +438,24 @@
"message": "Just for formality could you please add fields with assignee(s), work items, some words about testing and documentation?",
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bc9e5af4_01f4f533",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 358,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "Ack, will do.",
"parentUuid": "cbeb5ee2_0255c76e",
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}