Update patch set 1
Patch Set 1: (11 inline comments) Patch-set: 1 Label: Code-Review=0
This commit is contained in:
parent
a7e98a996c
commit
e7feaf6f53
|
@ -17,6 +17,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//tm0\u003d",
|
||||
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 13,
|
||||
"author": {
|
||||
"id": 8645
|
||||
},
|
||||
"writtenOn": "2014-04-18T01:33:57Z",
|
||||
"side": 1,
|
||||
"message": "I will remove the spaces and upload the new draft",
|
||||
"parentUuid": "AAAAXH//wzQ\u003d",
|
||||
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//wQc\u003d",
|
||||
|
@ -68,6 +86,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//tmc\u003d",
|
||||
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 32,
|
||||
"author": {
|
||||
"id": 8645
|
||||
},
|
||||
"writtenOn": "2014-04-18T01:33:57Z",
|
||||
"side": 1,
|
||||
"message": "okay",
|
||||
"parentUuid": "AAAAXH//vyc\u003d",
|
||||
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//wRk\u003d",
|
||||
|
@ -85,6 +121,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//tmA\u003d",
|
||||
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 49,
|
||||
"author": {
|
||||
"id": 8645
|
||||
},
|
||||
"writtenOn": "2014-04-18T01:33:57Z",
|
||||
"side": 1,
|
||||
"message": "will handle in new draft patchset",
|
||||
"parentUuid": "AAAAXH//wRk\u003d",
|
||||
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//wRM\u003d",
|
||||
|
@ -102,6 +156,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//tk8\u003d",
|
||||
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 50,
|
||||
"author": {
|
||||
"id": 8645
|
||||
},
|
||||
"writtenOn": "2014-04-18T01:33:57Z",
|
||||
"side": 1,
|
||||
"message": "MD does bind-port and ubind-port operations as the Openvswitch agent does. these definitions are called when ml2 is configured with mechanism drivers fslsdn and openvswitch.",
|
||||
"parentUuid": "AAAAXH//wRM\u003d",
|
||||
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//vxE\u003d",
|
||||
|
@ -119,6 +191,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//tkk\u003d",
|
||||
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 61,
|
||||
"author": {
|
||||
"id": 8645
|
||||
},
|
||||
"writtenOn": "2014-04-18T01:33:57Z",
|
||||
"side": 1,
|
||||
"message": "CRD service a new openstack neutron kind of service developed internally. is has its own database schema and keystone authentication credentials. No data releated to CRD is stored in Neutron data models. I will update the draft",
|
||||
"parentUuid": "AAAAXH//vxE\u003d",
|
||||
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//wQg\u003d",
|
||||
|
@ -153,6 +243,42 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//tjA\u003d",
|
||||
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 81,
|
||||
"author": {
|
||||
"id": 8645
|
||||
},
|
||||
"writtenOn": "2014-04-18T01:33:57Z",
|
||||
"side": 1,
|
||||
"message": "misframed statement. CRD service is a neutron kind of service we developed for openstack internally.",
|
||||
"parentUuid": "AAAAXH//v1M\u003d",
|
||||
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//tjk\u003d",
|
||||
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 81,
|
||||
"author": {
|
||||
"id": 8645
|
||||
},
|
||||
"writtenOn": "2014-04-18T01:33:57Z",
|
||||
"side": 1,
|
||||
"message": "Using latest neutron client, service-type, service and user-agent variables are hardcoded which we felt required to the configured. Since these variables are important for CRD service authentication, we went with a customized http client api from neutronclient http client api.",
|
||||
"parentUuid": "AAAAXH//wQg\u003d",
|
||||
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//v0Q\u003d",
|
||||
|
@ -170,6 +296,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//tiI\u003d",
|
||||
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 87,
|
||||
"author": {
|
||||
"id": 8645
|
||||
},
|
||||
"writtenOn": "2014-04-18T01:33:57Z",
|
||||
"side": 1,
|
||||
"message": "The impact is negligible.",
|
||||
"parentUuid": "AAAAXH//v0Q\u003d",
|
||||
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//vwU\u003d",
|
||||
|
@ -187,6 +331,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//thc\u003d",
|
||||
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 92,
|
||||
"author": {
|
||||
"id": 8645
|
||||
},
|
||||
"writtenOn": "2014-04-18T01:33:57Z",
|
||||
"side": 1,
|
||||
"message": "I mean to say, by default this will not affect neutron configuration, If fslsdn mechanism driver is enabled in neutron, then driver specific configuration are required.",
|
||||
"parentUuid": "AAAAXH//vwU\u003d",
|
||||
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//vwA\u003d",
|
||||
|
@ -204,6 +366,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//thY\u003d",
|
||||
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 122,
|
||||
"author": {
|
||||
"id": 8645
|
||||
},
|
||||
"writtenOn": "2014-04-18T01:33:57Z",
|
||||
"side": 1,
|
||||
"message": "okay.. Since I\u0027m using certain apis from neutron they might be dependencies. Will update in the next patchset today.",
|
||||
"parentUuid": "AAAAXH//vwA\u003d",
|
||||
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//vvg\u003d",
|
||||
|
@ -220,6 +400,24 @@
|
|||
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAXH//tg0\u003d",
|
||||
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 127,
|
||||
"author": {
|
||||
"id": 8645
|
||||
},
|
||||
"writtenOn": "2014-04-18T01:33:57Z",
|
||||
"side": 1,
|
||||
"message": "Existsing tempest tests which are al applicable for all ml2 mechanism drivers are also applicable for this mechanism driver",
|
||||
"parentUuid": "AAAAXH//vvg\u003d",
|
||||
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue