Update patch set 10
Patch Set 10: Code-Review+2 (3 comments) Patch-set: 10 Reviewer: Gerrit User 16688 <16688@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+2, e9f128125603bf5f8303258326b1c93b7f1acdc4 Attention: {"person_ident":"Gerrit User 4694 \u003c4694@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_16688\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 16688 \u003c16688@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_16688\u003e replied on the change"}
This commit is contained in:
parent
52f8572885
commit
eba9bb458a
|
@ -0,0 +1,67 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "26d483a7_eefc1ce3",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 16688
|
||||
},
|
||||
"writtenOn": "2023-06-27T10:25:24Z",
|
||||
"side": 1,
|
||||
"message": "Thanks for this proposal. Now I\u0027m waiting for the big refactor ahead in the OVN L3 plugin!",
|
||||
"revId": "8a0eaebf9a26b86cd63515ef304899d308f369c7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "9d385ae2_a70302fb",
|
||||
"filename": "specs/2023.2/ml2ovn-router-flavors.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 164,
|
||||
"author": {
|
||||
"id": 16688
|
||||
},
|
||||
"writtenOn": "2023-06-27T10:25:24Z",
|
||||
"side": 1,
|
||||
"message": "We should have stevedore entry points to make this name shorter. But this is more an implementation consideration.",
|
||||
"range": {
|
||||
"startLine": 164,
|
||||
"startChar": 116,
|
||||
"endLine": 164,
|
||||
"endChar": 182
|
||||
},
|
||||
"revId": "8a0eaebf9a26b86cd63515ef304899d308f369c7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "fe378c25_90162b49",
|
||||
"filename": "specs/2023.2/ml2ovn-router-flavors.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 197,
|
||||
"author": {
|
||||
"id": 16688
|
||||
},
|
||||
"writtenOn": "2023-06-27T10:25:24Z",
|
||||
"side": 1,
|
||||
"message": "It is surprising that we don\u0027t need any new API, but I think it is correct. Same for the DB schema.",
|
||||
"range": {
|
||||
"startLine": 197,
|
||||
"startChar": 1,
|
||||
"endLine": 197,
|
||||
"endChar": 29
|
||||
},
|
||||
"revId": "8a0eaebf9a26b86cd63515ef304899d308f369c7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue