{ "comments": [ { "unresolved": false, "key": { "uuid": "9a7a8271_36b14cff", "filename": "/PATCHSET_LEVEL", "patchSetId": 1 }, "lineNbr": 0, "author": { "id": 16688 }, "writtenOn": "2022-10-03T16:11:48Z", "side": 1, "message": "-1 for visibility only", "revId": "acb511c1e54758b3457b1a90c910255a0315d4f9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "b716d2b6_c364af6f", "filename": "specs/2023.1/configurable-default-sg-rules.rst", "patchSetId": 1 }, "lineNbr": 21, "author": { "id": 8313 }, "writtenOn": "2022-09-22T09:57:51Z", "side": 1, "message": "nit; these should be # to have numbered list (I think) as you reference them by number below", "range": { "startLine": 21, "startChar": 0, "endLine": 21, "endChar": 1 }, "revId": "acb511c1e54758b3457b1a90c910255a0315d4f9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "6a9272f2_45780725", "filename": "specs/2023.1/configurable-default-sg-rules.rst", "patchSetId": 1 }, "lineNbr": 21, "author": { "id": 16688 }, "writtenOn": "2022-10-03T16:11:48Z", "side": 1, "message": "+1", "parentUuid": "b716d2b6_c364af6f", "range": { "startLine": 21, "startChar": 0, "endLine": 21, "endChar": 1 }, "revId": "acb511c1e54758b3457b1a90c910255a0315d4f9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "e56e1cb0_d79926d8", "filename": "specs/2023.1/configurable-default-sg-rules.rst", "patchSetId": 1 }, "lineNbr": 26, "author": { "id": 8313 }, "writtenOn": "2022-09-22T09:57:51Z", "side": 1, "message": "the so liked remote groups:-)", "range": { "startLine": 23, "startChar": 0, "endLine": 26, "endChar": 32 }, "revId": "acb511c1e54758b3457b1a90c910255a0315d4f9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "2d64ed23_570e1dfb", "filename": "specs/2023.1/configurable-default-sg-rules.rst", "patchSetId": 1 }, "lineNbr": 36, "author": { "id": 16688 }, "writtenOn": "2022-10-03T16:11:48Z", "side": 1, "message": "nit: \"it is a known fact the the security group rules\"", "range": { "startLine": 36, "startChar": 2, "endLine": 36, "endChar": 32 }, "revId": "acb511c1e54758b3457b1a90c910255a0315d4f9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "4110994a_7c213659", "filename": "specs/2023.1/configurable-default-sg-rules.rst", "patchSetId": 1 }, "lineNbr": 41, "author": { "id": 8313 }, "writtenOn": "2022-09-22T09:57:51Z", "side": 1, "message": "nit:easily", "range": { "startLine": 41, "startChar": 60, "endLine": 41, "endChar": 64 }, "revId": "acb511c1e54758b3457b1a90c910255a0315d4f9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "79df8c4b_9722b211", "filename": "specs/2023.1/configurable-default-sg-rules.rst", "patchSetId": 1 }, "lineNbr": 51, "author": { "id": 8313 }, "writtenOn": "2022-09-22T09:57:51Z", "side": 1, "message": "for the given tenant?", "revId": "acb511c1e54758b3457b1a90c910255a0315d4f9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "c474ee1a_6d70eefc", "filename": "specs/2023.1/configurable-default-sg-rules.rst", "patchSetId": 1 }, "lineNbr": 51, "author": { "id": 16688 }, "writtenOn": "2022-10-03T16:11:48Z", "side": 1, "message": "hmmm, I\u0027m not sure the default SG rules are per project but per cloud.", "parentUuid": "79df8c4b_9722b211", "revId": "acb511c1e54758b3457b1a90c910255a0315d4f9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "c201f554_1ec931cc", "filename": "specs/2023.1/configurable-default-sg-rules.rst", "patchSetId": 1 }, "lineNbr": 52, "author": { "id": 8313 }, "writtenOn": "2022-09-22T09:57:51Z", "side": 1, "message": "nit: hardcoded", "range": { "startLine": 52, "startChar": 49, "endLine": 52, "endChar": 57 }, "revId": "acb511c1e54758b3457b1a90c910255a0315d4f9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "333f5c83_c17726a4", "filename": "specs/2023.1/configurable-default-sg-rules.rst", "patchSetId": 1 }, "lineNbr": 52, "author": { "id": 16688 }, "writtenOn": "2022-10-03T16:11:48Z", "side": 1, "message": "nit: compatibility", "range": { "startLine": 52, "startChar": 17, "endLine": 52, "endChar": 30 }, "revId": "acb511c1e54758b3457b1a90c910255a0315d4f9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "04fdd584_5775abb1", "filename": "specs/2023.1/configurable-default-sg-rules.rst", "patchSetId": 1 }, "lineNbr": 65, "author": { "id": 16688 }, "writtenOn": "2022-10-03T16:11:48Z", "side": 1, "message": "Question 1: what are the default default SG rules (note I intentionally used the word \"default\" twice) that a new system will have? None? The 4 existing ones for the default SG?\n\nQuestion 2: for the default security group we create now 4 rules. For a new SG, we always create 2 rules. Will we have two templates, one for the default SG and another one for the default rules to be added in a normal SG?", "range": { "startLine": 65, "startChar": 7, "endLine": 65, "endChar": 35 }, "revId": "acb511c1e54758b3457b1a90c910255a0315d4f9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "3eaa5554_92dc439c", "filename": "specs/2023.1/configurable-default-sg-rules.rst", "patchSetId": 1 }, "lineNbr": 229, "author": { "id": 8313 }, "writtenOn": "2022-09-22T09:57:51Z", "side": 1, "message": "Is PUT planned to be supported?\nWould have strange anyway, would effect for the next created groups only, or such", "revId": "acb511c1e54758b3457b1a90c910255a0315d4f9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "25cc6daa_f092e6cb", "filename": "specs/2023.1/configurable-default-sg-rules.rst", "patchSetId": 1 }, "lineNbr": 229, "author": { "id": 16688 }, "writtenOn": "2022-10-03T16:11:48Z", "side": 1, "message": "That\u0027s only my opinion, but if we are going to define global resources, like those default SG rules, I would prefer to use statically defined rules. In other words, not to be able to modify them.", "parentUuid": "3eaa5554_92dc439c", "revId": "acb511c1e54758b3457b1a90c910255a0315d4f9", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] }