openstack
/
neutron-specs
Code Issues Proposed changes
neutron-specs/8ce21d40eda0f8392fb6d4cd506...

485 lines
16 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "304a229b_11e5bc65",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 50,
"author": {
"id": 8313
},
"writtenOn": "2023-02-09T14:59:46Z",
"side": 1,
"message": "Perhaps easier to understand: \"ECMP routes can result in black-holing of traffic if the next hop of a route becomes unreachable\"\n(I hope I understand well what your intention is here)",
"range": {
"startLine": 49,
"startChar": 0,
"endLine": 50,
"endChar": 26
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2924bb73_19409c94",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 50,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "Yes, you got it right - I think your version is better. I need to have less clericalism in the text :^)",
"parentUuid": "304a229b_11e5bc65",
"range": {
"startLine": 49,
"startChar": 0,
"endLine": 50,
"endChar": 26
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "63d8587c_ec4b4165",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 53,
"author": {
"id": 8313
},
"writtenOn": "2023-02-09T14:59:46Z",
"side": 1,
"message": "Perhaps a word at least should be here about the possible performance impact, I checked BFD for OVS (I suppose OVN also sets OVSdb fields finally) and OVS sends out BFD messages, so it can have performance impact finally",
"range": {
"startLine": 53,
"startChar": 0,
"endLine": 53,
"endChar": 78
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9799e8f8_8a6688ad",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 53,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "Yes, having too many sessions is a concern.\n\nWe could approach it in various to reduce the number of sessions, e.g. use a \"shared\" router in an admin project and an intermediate virtual network through which other other routers would connect to it or something else.\n\nThis also raises an RBAC-related concern: letting random tenants configure BFD probably isn\u0027t a good idea so we may require changing BFD parameters to be a cloud admin only operation.",
"parentUuid": "63d8587c_ec4b4165",
"range": {
"startLine": 53,
"startChar": 0,
"endLine": 53,
"endChar": 78
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "eb830915_777dfe10",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 53,
"author": {
"id": 13686
},
"writtenOn": "2023-02-10T14:31:39Z",
"side": 1,
"message": "ftr; the OVN BFD implementation for routes is actually handled as packet-ins to the ovn-controller, so they do not use the OVS BFD implementation for this part. Performance impact still applies though.\n\nThe OVS BFD implementation is still used on tunnel endpoints for liveness detection between chassis.",
"parentUuid": "9799e8f8_8a6688ad",
"range": {
"startLine": 53,
"startChar": 0,
"endLine": 53,
"endChar": 78
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d7b99645_e43d6c6c",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 92,
"author": {
"id": 8313
},
"writtenOn": "2023-02-09T14:59:46Z",
"side": 1,
"message": "+1, this still seems to be a good way to keep the old behaviour and extend it",
"range": {
"startLine": 86,
"startChar": 0,
"endLine": 92,
"endChar": 59
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "558e2ae7_ee1a10d1",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 92,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "Ack",
"parentUuid": "d7b99645_e43d6c6c",
"range": {
"startLine": 86,
"startChar": 0,
"endLine": 92,
"endChar": 59
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ab75e3db_73cd523d",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 118,
"author": {
"id": 8313
},
"writtenOn": "2023-02-09T14:59:46Z",
"side": 1,
"message": "ditto, I vote for add API of cfg option for it, even as a \"merged\" option together with enable_default_route_ecmp",
"range": {
"startLine": 116,
"startChar": 0,
"endLine": 118,
"endChar": 36
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e32e247c_87286462",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 131,
"author": {
"id": 8313
},
"writtenOn": "2023-02-09T14:59:46Z",
"side": 1,
"message": "...route to use....?",
"range": {
"startLine": 131,
"startChar": 56,
"endLine": 131,
"endChar": 65
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ba6d8854_a172fc2f",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 131,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "Thanks for spotting, I\u0027ll fix it.",
"parentUuid": "e32e247c_87286462",
"range": {
"startLine": 131,
"startChar": 56,
"endLine": 131,
"endChar": 65
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e4c826d7_281520bd",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 144,
"author": {
"id": 8313
},
"writtenOn": "2023-02-09T14:59:46Z",
"side": 1,
"message": "min_tx",
"range": {
"startLine": 144,
"startChar": 4,
"endLine": 144,
"endChar": 10
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "183f365e_7c807010",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 144,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "ty, definitely a typo.",
"parentUuid": "e4c826d7_281520bd",
"range": {
"startLine": 144,
"startChar": 4,
"endLine": 144,
"endChar": 10
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b1acda2c_49e58f5f",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 167,
"author": {
"id": 8313
},
"writtenOn": "2023-02-09T14:59:46Z",
"side": 1,
"message": "agree, I think these things (like min_tx and min_rx) can be defaulted or in worst case we can add some cfg option for it",
"range": {
"startLine": 163,
"startChar": 0,
"endLine": 167,
"endChar": 22
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d10aacbc_4a886ed6",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 192,
"author": {
"id": 8313
},
"writtenOn": "2023-02-09T14:59:46Z",
"side": 1,
"message": "Is this part of this spec?",
"range": {
"startLine": 192,
"startChar": 60,
"endLine": 192,
"endChar": 74
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b7e6b7cd_d1d8d49f",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 192,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "Sorry, I took a subset of definitions from the BFD support spec for compatibility with it:\n\nhttps://specs.openstack.org/openstack/neutron-specs/specs/xena/bfd_support.html\n\nBut I missed editing this part of the description - thanks for spotting it.\n\nI\u0027ll change this part.",
"parentUuid": "d10aacbc_4a886ed6",
"range": {
"startLine": 192,
"startChar": 60,
"endLine": 192,
"endChar": 74
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ac964aee_093d09fe",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 248,
"author": {
"id": 24824
},
"writtenOn": "2023-01-25T08:24:11Z",
"side": 1,
"message": "Note that there is a bug related to default routes not being added to OVN NB if a segment_id of a subnet is not set to `None`:\n\nhttps://bugs.launchpad.net/neutron/+bug/2003842\n\nThis bug needs to be fixed to properly support the multiple gateways on a multi-segment network case but it affects Neutron as it is even without this feature.",
"range": {
"startLine": 248,
"startChar": 14,
"endLine": 248,
"endChar": 40
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3d2e3115_907474f6",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 248,
"author": {
"id": 24824
},
"writtenOn": "2023-02-02T19:19:54Z",
"side": 1,
"message": "Discussed that further with Rodolfo\n\nhttps://meetings.opendev.org/irclogs/%23openstack-neutron/%23openstack-neutron.2023-01-27.log.html#t2023-01-27T14:30:42\n\nand the case where a gateway is created on a multi-segment network will not be supported.\n\nHowever, having gateways on different single-segment networks raises a different question: subnets on those networks may potentially overlap unless they have subnets allocated from the same subnet pool (i.e. they are in the same address scope).\n\nOverlapping subnets lead to a situation where a next hop of a default route is reachable via directly connected routes added for either of the gateways and can inadvertently create a black hole (on a different segment that next-hop IP might not be a router or may not be assigned but we\u0027d still get a logical flow for it). BFD would limit the impact of that to a degree. We could also get into a situation where next hops themselves would match in which case there would be a conflict during a route addition (while routes have a matching 0.0.0.0/0 destination and next-hop they have a different address scope/VRF).\n\nI am going to explore how to guard an operator against that.",
"parentUuid": "ac964aee_093d09fe",
"range": {
"startLine": 248,
"startChar": 14,
"endLine": 248,
"endChar": 40
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "23739657_cb257ff6",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 310,
"author": {
"id": 8313
},
"writtenOn": "2023-02-09T15:03:46Z",
"side": 1,
"message": "You mentioned a status field, but that is only for the db record, am I understand well? How the user can check that on the API?",
"range": {
"startLine": 306,
"startChar": 0,
"endLine": 310,
"endChar": 70
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "12ea247b_9cc56859",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 310,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "I think we\u0027ll need an API for this that goes with this spec to have that visibility:\n\nhttps://specs.openstack.org/openstack/neutron-specs/specs/xena/bfd_support.html",
"parentUuid": "23739657_cb257ff6",
"range": {
"startLine": 306,
"startChar": 0,
"endLine": 310,
"endChar": 70
},
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cbeb5ee2_0255c76e",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 358,
"author": {
"id": 8313
},
"writtenOn": "2023-02-09T15:03:46Z",
"side": 1,
"message": "Just for formality could you please add fields with assignee(s), work items, some words about testing and documentation?",
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bc9e5af4_01f4f533",
"filename": "specs/2023.1/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 2
},
"lineNbr": 358,
"author": {
"id": 24824
},
"writtenOn": "2023-02-10T14:04:48Z",
"side": 1,
"message": "Ack, will do.",
"parentUuid": "cbeb5ee2_0255c76e",
"revId": "8ce21d40eda0f8392fb6d4cd5068298e16f3b7ca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink